Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers

From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers
Date	2017-02-27 23:40 +0100
Message-ID	<tfAS5-2SI-5@gated-at.bofh.it> (permalink)
References	(3 earlier) <tftdU-5Yo-25@gated-at.bofh.it> <tfA5I-2i1-17@gated-at.bofh.it> <tfA5I-2i1-15@gated-at.bofh.it> <tfAfo-2lV-13@gated-at.bofh.it> <tfAp4-2r5-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello, Tahsin.

On Mon, Feb 27, 2017 at 12:37:59PM -0800, Tahsin Erdogan wrote:
> > Ah, absolutely, that's a stupid failure but we should be able to fix
> > that by making the blkg functions take gfp mask and allocate
> > accordingly, right?  It'll probably take preallocation tricks because
> > of locking but should be doable.
> 
> My initial goal was to allow calls to vmalloc(), but I now see the
> challenges in that
> approach.

I'd love to see that working too but this is a different issue.  Even
GFP_ATOMIC can fail under pressure and it's kinda wrong to depend on
that for userspace interactions.

> Doing preallocations would probably work but not sure if that can be
> done without
> complicating code too much. Could you describe what you have in mind?

So, blkg_create() already takes @new_blkg argument which is the
preallocated blkg and used during q init.  Wouldn't it work to make
blkg_lookup_create() take @new_blkg too and pass it down to
blkg_create() (and also free it if it doesn't get used)?  Then,
blkg_conf_prep() can always (or after a failure with -ENOMEM) allocate
a new blkg before calling into blkg_lookup_create().  I don't think
it'll complicate the code path that much.

Thanks.

-- 
tejun

Thread

[PATCH 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-25 22:10 +0100
  Re: [PATCH 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers kbuild test robot <lkp@intel.com> - 2017-02-26 01:00 +0100
  Re: [PATCH 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers kbuild test robot <lkp@intel.com> - 2017-02-26 01:50 +0100
    [PATCH v2 3/3] percpu: improve allocation success rate for non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-26 05:50 +0100
      Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 11:20 +0100
        Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 14:10 +0100
          Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 16:30 +0100
            Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 18:10 +0100
              Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 18:40 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 20:40 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Michal Hocko <mhocko@kernel.org> - 2017-02-27 20:50 +0100
            Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 18:10 +0100
          Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 21:30 +0100
            Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 21:40 +0100
              Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 21:50 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tahsin Erdogan <tahsin@google.com> - 2017-02-27 22:20 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 22:40 +0100
                Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 23:40 +0100
          Re: [PATCH v2 3/3] percpu: improve allocation success rate for  non-GFP_KERNEL callers Tejun Heo <tj@kernel.org> - 2017-02-27 23:40 +0100

csiph-web