Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588339

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups

Show all headers | View raw

On Sun, Feb 26, 2017 at 1:30 PM, Michał Kępień <kernel@kempniu.pl> wrote:
>> On Fri, Feb 17, 2017 at 6:17 AM, Jonathan Woithe <jwoithe@just42.net> wrote:
>> > On Thu, Feb 16, 2017 at 07:53:19PM -0800, Darren Hart wrote:
>> >> On Fri, Feb 17, 2017 at 01:38:04PM +1030, Jonathan Woithe wrote:
>> >> > Do you want me to continue to use Acked-by, or should I switch to
>> >> > Reviewed-by?
>> >>
>> >> These tags do have different meanings, and have come up at Kernel Summit the
>> >> last couple of years. My interpretation of those discussions is:
>> >>
>> >> Acked-by: I have no objection to this patch, but I didn't really give it a
>> >> thorough review. I trust your judgement. e.g. minor change to your driver to
>> >> support a subsystem API change. These are of very little value.
>> >>
>> >> Reviewed-by: I have carefully reviewed this patch and would like it to be
>> >> applied. This should usually come with some sort of commentary describing the
>> >> level of review or an area you focused on. This is what we would like to see
>> >> from all of our driver maintainers. These are high value.
>> >>
>> >> Linus *really* dislikes one line acked by's, and only *slightly* more so than
>> >> one line reviewed by's. :-)
>> >
>> > Got it, thanks, this is very helpful.
>> >
>> > In light of this I give you the following.
>> >
>> > Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
>>
>> Thanks, applied for testing with above tag.
>
> Andy,
>
> It looks like you missed this part of Jonathan's message:

Indeed.

>
>> As per subsequent discussion we have agreed to drop patch 8/10 from the
>> series: it creates problems on newer hardware and the issue it is addressing
>> will be more completely dealt with in a subsequent patch series.
>
> I see that patch 8/10 was applied to testing as well.  Could you please
> drop that single patch?

Good we have testing branch and thank you for pointing out. Should be fixed now.

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Darren Hart <dvhart@infradead.org> - 2017-02-17 04:00 +0100
  Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Jonathan Woithe <jwoithe@just42.net> - 2017-02-17 04:10 +0100
    Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Darren Hart <dvhart@infradead.org> - 2017-02-17 05:00 +0100
      Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Jonathan Woithe <jwoithe@just42.net> - 2017-02-17 05:20 +0100
        Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Darren Hart <dvhart@infradead.org> - 2017-02-17 06:30 +0100
        Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-24 21:40 +0100
          Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Michał Kępień <kernel@kempniu.pl> - 2017-02-26 12:40 +0100
            Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-26 16:20 +0100
      Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Michał Kępień <kernel@kempniu.pl> - 2017-02-17 08:20 +0100
        Re: [PATCH 00/10] fujitsu-laptop: renames and cleanups Darren Hart <dvhart@infradead.org> - 2017-02-24 23:20 +0100

csiph-web