Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1588312

Re: [GIT PULL] Kselftest update for 4.11-rc1

Show all headers | View raw

On Sat, Feb 25, 2017 at 03:42:55PM -0800, Linus Torvalds wrote:
> On Fri, Feb 24, 2017 at 1:09 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> >
> > Stephen saw a conflict during kselftest merge with next
> [..]
> 
> There was also a conflict with some of Andrew's new userfaultfd tests.
> 
> I'm not at all sure I merged that correctly, although I tried to make
> the resolution at least look sane. The odd thing about those new tests
> is that it's all the same source file, except built with different
> compile-time defines to be different test binaries.
> 
> I didn't find any way to do that with any standard selftest makefile
> magic, so I just did the build rules by hand.
> 
> Somebody should actually verify that it does the right thing, please..
> Adding the two Mike's that did those test additions to the participant
> list.

The userfaultfd_* tests are built and they are working just fine.
Maybe it's worth adding userfaultfd_{hugetlb,shmem}.c which will define the
required defines and include userfaultfd.c?
Than we can get away with only specifying LDFLAGS += -lpthread in the
Makefile.
 
>                                Linus
>

--
Sincerely yours,
Mike.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [GIT PULL] Kselftest update for 4.11-rc1 Linus Torvalds <torvalds@linux-foundation.org> - 2017-02-26 00:50 +0100
  Re: [GIT PULL] Kselftest update for 4.11-rc1 Mike Rapoport <rppt@linux.vnet.ibm.com> - 2017-02-26 12:40 +0100
    Re: [GIT PULL] Kselftest update for 4.11-rc1 Mike Kravetz <mike.kravetz@oracle.com> - 2017-02-26 22:10 +0100
      Re: [GIT PULL] Kselftest update for 4.11-rc1 Andrea Arcangeli <aarcange@redhat.com> - 2017-02-27 23:20 +0100

csiph-web