Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings
Date	2017-02-24 17:20 +0100
Message-ID	<teqL7-2Ds-5@gated-at.bofh.it> (permalink)
References	<te10m-1jJ-9@gated-at.bofh.it> <te10m-1jJ-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: kbuild test robot <fengguang.wu@intel.com>
Date: Thu, 23 Feb 2017 20:47:01 +0800

> net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
> 
>  NULL check before some freeing functions is not needed.
> 
>  Based on checkpatch warning
>  "kfree(NULL) is safe this check is probably not required"
>  and kfreeaddr.cocci by Julia Lawall.
> 
> Generated by: scripts/coccinelle/free/ifnullfree.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions  like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not  needed. Maybe consider reorganizing relevant code to avoid passing NULL  values. kbuild test robot <fengguang.wu@intel.com> - 2017-02-23 13:50 +0100
  [PATCH] RDS: IB: fix ifnullfree.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-02-23 13:50 +0100
    Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-02-23 17:40 +0100
    Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings David Miller <davem@davemloft.net> - 2017-02-24 17:20 +0100

csiph-web