Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586867
| From | kbuild test robot <fengguang.wu@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] RDS: IB: fix ifnullfree.cocci warnings |
| Date | 2017-02-23 13:50 +0100 |
| Message-ID | <te10m-1jJ-27@gated-at.bofh.it> (permalink) |
| References | <te10m-1jJ-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> --- ib.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/net/rds/ib.c +++ b/net/rds/ib.c @@ -111,8 +111,7 @@ static void rds_ib_dev_free(struct work_ kfree(i_ipaddr); } - if (rds_ibdev->vector_load) - kfree(rds_ibdev->vector_load); + kfree(rds_ibdev->vector_load); kfree(rds_ibdev); }
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
net/rds/ib.c:115:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. kbuild test robot <fengguang.wu@intel.com> - 2017-02-23 13:50 +0100
[PATCH] RDS: IB: fix ifnullfree.cocci warnings kbuild test robot <fengguang.wu@intel.com> - 2017-02-23 13:50 +0100
Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-02-23 17:40 +0100
Re: [PATCH] RDS: IB: fix ifnullfree.cocci warnings David Miller <davem@davemloft.net> - 2017-02-24 17:20 +0100
csiph-web