[PATCH 12/14] afs: security: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH 12/14] afs: security: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Date	2017-02-24 14:20 +0100
Message-ID	<tenWW-FB-39@gated-at.bofh.it> (permalink)
References	<tenWV-FB-21@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

From: Andreea-Cristina Bernat <bernat.ada@gmail.com>

The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
"1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
  (..., NULL)

Signed-off-by: Andreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 fs/afs/security.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/afs/security.c b/fs/afs/security.c
index bfa9d3428383..ecb86a670180 100644
--- a/fs/afs/security.c
+++ b/fs/afs/security.c
@@ -114,7 +114,7 @@ void afs_clear_permits(struct afs_vnode *vnode)
 
 	mutex_lock(&vnode->permits_lock);
 	permits = vnode->permits;
-	rcu_assign_pointer(vnode->permits, NULL);
+	RCU_INIT_POINTER(vnode->permits, NULL);
 	mutex_unlock(&vnode->permits_lock);
 
 	if (permits)

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 12/14] afs: security: Replace rcu_assign_pointer() with  RCU_INIT_POINTER() David Howells <dhowells@redhat.com> - 2017-02-24 14:20 +0100

csiph-web