Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587471
| From | Lars-Peter Clausen <lars@metafoo.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support |
| Date | 2017-02-24 10:50 +0100 |
| Message-ID | <tekFI-6GV-7@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tdClj-aH-13@gated-at.bofh.it> <te4KC-3SM-37@gated-at.bofh.it> <te4Uj-3Wg-57@gated-at.bofh.it> <te4Uj-3Wg-55@gated-at.bofh.it> <tekcG-6wz-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/24/2017 10:12 AM, Eva Rachel Retuya wrote: > On Thu, Feb 23, 2017 at 06:58:12PM +0200, Andy Shevchenko wrote: >> On Thu, Feb 23, 2017 at 6:47 PM, Lars-Peter Clausen <lars@metafoo.de> wrote: >>> On 02/23/2017 05:43 PM, Andy Shevchenko wrote: >>>> On Wed, Feb 22, 2017 at 12:23 PM, Eva Rachel Retuya <eraretuya@gmail.com> wrote: >>>>> Add SPI driver that initializes SPI regmap for the adxl345 core driver. >>>>> The driver supports the same functionality as I2C namely the x, y, z and >>>>> scale readings. >> >>>>> config ADXL345_I2C >>>>> tristate >>>>> select REGMAP_I2C >>>>> >>>>> +config ADXL345_SPI >>>>> + tristate >>>>> + select REGMAP_SPI >>>> >>>> Hmm... >>>> I saw another pattern >>>> >>>> Library / core part is non-visible to user, while >>>> SPI and I2C parts are selectable by user. >>>> >>>> Why do you use inverted pattern? What did I miss? >>> >>> The first version of the patch used the other pattern SPI/I2C visible. >>> Jonathan suggested this other pattern. I prefer the explicit SPI/I2C visible >>> pattern, but in the end it doesn't really matter as long as both work. >> >> Yes, but this pattern makes extra footprint of the kernel and >> basically dead code when I would like, for example, to have SPI bus >> enabled, I2C module available, but SPI module not compiled. >> >> Other one is when I want to have one compiled in, one as a module by >> whatever reason. >> >> At the end I have no strong opinion, though rationale for the opposite is above. >> > > Hello Lars and Andy, > > I'll revert to the explicit SPI/I2C pattern in order to give more > freedom in configuring as per the scenarios previously stated. Please check with Jonathan before you do, in the end he'll have to apply the patch.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 4/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-22 11:30 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-23 17:50 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-23 18:00 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-24 10:20 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Lars-Peter Clausen <lars@metafoo.de> - 2017-02-24 10:50 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-24 12:50 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-24 15:40 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Jonathan Cameron <jic23@jic23.retrosnub.co.uk> - 2017-02-24 20:50 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Jonathan Cameron <jic23@kernel.org> - 2017-02-25 16:20 +0100
Re: [PATCH v3 4/4] iio: accel: adxl345: Add SPI support Lars-Peter Clausen <lars@metafoo.de> - 2017-02-23 18:10 +0100
csiph-web