Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585722

Re: [PATCH v2 1/3] module: verify address is read-only

Show all headers | View raw

On Mon, Feb 20, 2017 at 9:14 AM, Stephen Hemminger
<stephen@networkplumber.org> wrote:
> On Fri, 17 Feb 2017 21:58:42 -0800
> "Eddie Kovsky" <ewk@edkovsky.org> wrote:
>
>> Implement a mechanism to check if a module's address is in
>> the rodata or ro_after_init sections. It mimics the exsiting functions
>> that test if an address is inside a module's text section.
>>
>> Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>
>
> I don't see the point of this for many of the hyper-v functions.
> They are only called from a small number of places, and this can be validated
> by code inspection. Adding this seems just seems to be code bloat to me.

I think it has value in that it effectively blocks any way for
non-ro_after_init structures from being passed into these functions.
Since there are so few callers now, it's the perfect place to add
this.

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] provide check for ro_after_init memory sections Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
  [PATCH v2 2/3] extable: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
    Re: [PATCH v2 2/3] extable: verify address is read-only kbuild test robot <lkp@intel.com> - 2017-02-18 07:40 +0100
  [PATCH v2 1/3] module: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
    Re: [PATCH v2 1/3] module: verify address is read-only Stephen Hemminger <stephen@networkplumber.org> - 2017-02-20 18:20 +0100
      Re: [PATCH v2 1/3] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-02-21 21:40 +0100
        Re: [PATCH v2 1/3] module: verify address is read-only Stephen Hemminger <stephen@networkplumber.org> - 2017-02-21 22:00 +0100
    Re: [PATCH v2 1/3] module: verify address is read-only Jessica Yu <jeyu@redhat.com> - 2017-02-26 18:50 +0100

csiph-web