Re: [PATCH v2 1/3] module: verify address is read-only

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/3] module: verify address is read-only
Date	2017-02-21 22:00 +0100
Message-ID	<tdpHr-7P4-7@gated-at.bofh.it> (permalink)
References	<tc6nv-6t9-3@gated-at.bofh.it> <tc6nv-6t9-5@gated-at.bofh.it> <tcZN0-7x5-21@gated-at.bofh.it> <tdpo7-7FL-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 21 Feb 2017 12:32:16 -0800
Kees Cook <keescook@chromium.org> wrote:

> On Mon, Feb 20, 2017 at 9:14 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Fri, 17 Feb 2017 21:58:42 -0800
> > "Eddie Kovsky" <ewk@edkovsky.org> wrote:
> >  
> >> Implement a mechanism to check if a module's address is in
> >> the rodata or ro_after_init sections. It mimics the exsiting functions
> >> that test if an address is inside a module's text section.
> >>
> >> Signed-off-by: Eddie Kovsky <ewk@edkovsky.org>  
> >
> > I don't see the point of this for many of the hyper-v functions.
> > They are only called from a small number of places, and this can be validated
> > by code inspection. Adding this seems just seems to be code bloat to me.  
> 
> I think it has value in that it effectively blocks any way for
> non-ro_after_init structures from being passed into these functions.
> Since there are so few callers now, it's the perfect place to add
> this.
> 
> -Kees
> 

Maybe for a more used API, but for such a corner case it is code bloat.

Thread

[PATCH v2 0/3] provide check for ro_after_init memory sections Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
  [PATCH v2 2/3] extable: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
    Re: [PATCH v2 2/3] extable: verify address is read-only kbuild test robot <lkp@intel.com> - 2017-02-18 07:40 +0100
  [PATCH v2 1/3] module: verify address is read-only Eddie Kovsky <ewk@edkovsky.org> - 2017-02-18 07:10 +0100
    Re: [PATCH v2 1/3] module: verify address is read-only Stephen Hemminger <stephen@networkplumber.org> - 2017-02-20 18:20 +0100
      Re: [PATCH v2 1/3] module: verify address is read-only Kees Cook <keescook@chromium.org> - 2017-02-21 21:40 +0100
        Re: [PATCH v2 1/3] module: verify address is read-only Stephen Hemminger <stephen@networkplumber.org> - 2017-02-21 22:00 +0100
    Re: [PATCH v2 1/3] module: verify address is read-only Jessica Yu <jeyu@redhat.com> - 2017-02-26 18:50 +0100

csiph-web