Re: [PATCH] staging/ks7010: formatting updates.

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging/ks7010: formatting updates.
Date	2017-02-21 21:10 +0100
Message-ID	<tdoV3-7qR-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <tdjsl-3HS-1@gated-at.bofh.it> <tdjC2-3LX-9@gated-at.bofh.it> <tdmzU-5Lh-19@gated-at.bofh.it> <tdnFE-6qe-15@gated-at.bofh.it> <tdoBH-74H-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote:
> * Joe Perches <joe@perches.com> [2017-02-21 10:47:31 -0800]:
> 
> > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> > > * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]:
> > > 
> > > > The first declaration fit nicely on a single line.
> > > > The second one indeed has a few spaces instead of TABs in the
> > > > continuation line. But that can be fixed easily, without moving the
> > > > first parameter to a continuation line.
> > > 
> > > What would the proposed fix be? A combination of spaces and hard-tabs? I
> > > don't see checkpatch complaining about it, so that could work too.
> > 
> > Maximal initial tabs, followed by required spaces to align
> > to open parenthesis
> > 
> 
> Thank you Joe. I will change it accordingly. Is there a supplementary
> style guide that covers these finer details?

No, coding style just says

	Descendants are always substantially shorter than
	the parent and are placed substantially to the right

However alignment to the open parenthesis is a
pretty common style.

Thread

[PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 05:30 +0100
  Re: [PATCH] staging/ks7010: formatting updates. Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-21 09:00 +0100
    Re: [PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 15:20 +0100
      Re: [PATCH] staging/ks7010: formatting updates. Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-21 15:30 +0100
        Re: [PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 18:40 +0100
          Re: [PATCH] staging/ks7010: formatting updates. Joe Perches <joe@perches.com> - 2017-02-21 19:50 +0100
            Re: [PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 20:50 +0100
              Re: [PATCH] staging/ks7010: formatting updates. Joe Perches <joe@perches.com> - 2017-02-21 21:10 +0100
  [PATCHv2] Checkpatch fixes for staging/drivers/ks7010. Matthew Giassa <matthew@giassa.net> - 2017-02-22 23:30 +0100
    Re: [PATCHv2] Checkpatch fixes for staging/drivers/ks7010. Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:20 +0100
  [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors). Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
    Re: [PATCHv3 4/4] Changing alignment and indentation in function  prototypes so parameters line up to make checkpatch happy (no more  warnings/errors). Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-27 11:00 +0100
  [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
    [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses. Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
      [PATCHv3 2/4] Removing trailing whitespace in comment block. Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
        [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch. Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:30 +0100
      Re: [PATCHv3 1/4] Encasing macros with complex values (ie: base  value plus index) with parentheses. "Tobin C. Harding" <me@tobin.cc> - 2017-02-27 07:10 +0100

csiph-web