Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585375

Re: [PATCH] staging/ks7010: formatting updates.

Show all headers | View raw

Hi Matthew,

On Tue, Feb 21, 2017 at 3:12 PM, Matthew Giassa <matthew@giassa.net> wrote:
>>>  drivers/staging/ks7010/ks_wlan_ioctl.h | 80
>>> +++++++++++++++++-----------------
>>>  1 file changed, 41 insertions(+), 39 deletions(-)
>>>
>>> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
>>> b/drivers/staging/ks7010/ks_wlan_ioctl.h
>>> index 84554b6..00eec18 100644
>>> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
>>> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
>>
>>
>>>  #include "ks_wlan.h"
>>>  #include <linux/netdevice.h>
>>>
>>> -int ks_wlan_read_config_file(struct ks_wlan_private *priv);
>>> -int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
>>> -                            unsigned int commit_flag);
>>> +int ks_wlan_read_config_file(
>>> +               struct ks_wlan_private *priv);
>>> +int ks_wlan_setup_parameter(
>>> +               struct ks_wlan_private *priv,
>>> +               unsigned int commit_flag);
>>
>>
>> Really?
>> If checkpatch complained about the above, you should file a bug report
>> against checkpatch.
>
> It seems to be a very deliberate message from checkpatch, complaining
> about the alignment of the beginning of individual function parameters
> in the prototype. The only two configurations which appeased it was the
> changes I put in above, or a combination of hard-tabs (8-wide, noexpand)
> and spaces, which I thought was ugly.

The first declaration fit nicely on a single line.
The second one indeed has a few spaces instead of TABs in the
continuation line. But that can be fixed easily, without moving the
first parameter to a continuation line.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 05:30 +0100
  Re: [PATCH] staging/ks7010: formatting updates. Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-21 09:00 +0100
    Re: [PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 15:20 +0100
      Re: [PATCH] staging/ks7010: formatting updates. Geert Uytterhoeven <geert@linux-m68k.org> - 2017-02-21 15:30 +0100
        Re: [PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 18:40 +0100
          Re: [PATCH] staging/ks7010: formatting updates. Joe Perches <joe@perches.com> - 2017-02-21 19:50 +0100
            Re: [PATCH] staging/ks7010: formatting updates. Matthew Giassa <matthew@giassa.net> - 2017-02-21 20:50 +0100
              Re: [PATCH] staging/ks7010: formatting updates. Joe Perches <joe@perches.com> - 2017-02-21 21:10 +0100
  [PATCHv2] Checkpatch fixes for staging/drivers/ks7010. Matthew Giassa <matthew@giassa.net> - 2017-02-22 23:30 +0100
    Re: [PATCHv2] Checkpatch fixes for staging/drivers/ks7010. Greg KH <gregkh@linuxfoundation.org> - 2017-02-24 18:20 +0100
  [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors). Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
    Re: [PATCHv3 4/4] Changing alignment and indentation in function  prototypes so parameters line up to make checkpatch happy (no more  warnings/errors). Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-27 11:00 +0100
  [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
    [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses. Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
      [PATCHv3 2/4] Removing trailing whitespace in comment block. Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:10 +0100
        [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch. Matthew Giassa <matthew@giassa.net> - 2017-02-27 03:30 +0100
      Re: [PATCHv3 1/4] Encasing macros with complex values (ie: base  value plus index) with parentheses. "Tobin C. Harding" <me@tobin.cc> - 2017-02-27 07:10 +0100

csiph-web