Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1585585

[PATCH] staging: xgifb: function definition argument should have an identifier name

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From Arushi Singhal <arushisinghal19971997@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] staging: xgifb: function definition argument should have an identifier name
Date Tue, 21 Feb 2017 19:20:01 +0100
Message-ID <tdncB-6eZ-3@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=NiJfDk67LNNYUNmIEFjygZeFjf9gJSQ+yc3GogbP7HI=; b=tfmGOdxFiKh0YoXvkwJH0hqIzJnFFohfmk2yifXyAi+TDqf+Ra41INLJUoOmyGack6 ET2ebqmSzTb/Nyudl4jVbDay/b8fr4Y9Hj6n3Gd7+p2tp/3PJJ/0AuDxtnvZRlwvj9O0 npjVVNCQFfP4yLu94a1Un2JGcVg2xL8pdfb9BhWm1xJv3EQRbSnf6c3+K8fxKM23awVC zyDUmUi0KcDoM8cVE1aJ27lTUB8Aq0TiXLHQGzUOZ3HSo4jJWVpkQUC//Dayb82a7VqW rroQu2TPgTjr1TKpu0KloLRwROl/rJmCCy1qVeorfD4owshk4M9e42roxaoD7k3tt87T 1YJw==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=NiJfDk67LNNYUNmIEFjygZeFjf9gJSQ+yc3GogbP7HI=; b=cKfRGTbN+rYzgKJK825QD+lgvCYUS5c2lo7xyTiJrN1CetdQEhvQbwOjFY7sVREysJ 2ex5nfEe/Gd3sEsOBDptTlrNIPZ9XLsJY7/42NUsvWAt4MsAoHyf+9DzY701X7Bi5syV NHBoeIbuOEGNct1Y2hnpHpFPlp08xD6x4eUHllmvzd9oyrHV+BZ1fo5kLDFDTCBG6kNF JirDLUZE/aWX2JTikVlXVi1K1DC5zwHsuNXsezzoEyvP0yTXAySbZiAvoweZh3I5wR1i uUDnX5DtRTQwMeFTg5gm7v+1GV/wvFHBq39SsQMAOHTzdRIbuJzVVZt+i5/x7u+/6zsR e4ag==
X-Gm-Message-State AMke39lfDePbJgyMCaIyP9fbjeARfmvymBJj5EguwlJz/T+xULJWk9Sjs8ohkYu05187yQ==
X-Received by 10.99.243.21 with SMTP id l21mr36214371pgh.37.1487700537454; Tue, 21 Feb 2017 10:08:57 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 46
Organization linux.* mail to news gateway
X-Original-Cc Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
X-Original-Date Tue, 21 Feb 2017 23:38:53 +0530
X-Original-Message-ID <20170221180852.GA19723@arushi-HP-Pavilion-Notebook>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1585585

Show key headers only | View raw


function definition argument like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 drivers/staging/xgifb/vb_setmode.h | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
index 6f082a7a5a4a..e4cf9a633676 100644
--- a/drivers/staging/xgifb/vb_setmode.h
+++ b/drivers/staging/xgifb/vb_setmode.h
@@ -1,14 +1,15 @@
 #ifndef _VBSETMODE_
 #define _VBSETMODE_
 
-void InitTo330Pointer(unsigned char, struct vb_device_info *);
-void XGI_UnLockCRT2(struct vb_device_info *);
-void XGI_LockCRT2(struct vb_device_info *);
-void XGI_DisplayOff(struct xgifb_video_info *,
-		    struct xgi_hw_device_info *,
-		    struct vb_device_info *);
-void XGI_GetVBType(struct vb_device_info *);
-void XGI_SenseCRT1(struct vb_device_info *);
+void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo);
+void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
+void XGI_LockCRT2(struct vb_device_info *pVBInfo);
+void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
+		    struct xgi_hw_device_info *pXGIHWDE,
+		    struct vb_device_info *pVBInfo);
+void XGI_GetVBType(struct vb_device_info *pVBInfo);
+ 		pVBInfo->VBInfo = DisableCRT2Display;
+void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
 unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
 			    struct xgi_hw_device_info *HwDeviceExtension,
 			    unsigned short ModeNo);
@@ -18,6 +19,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,
 unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 				  unsigned short ModeNo,
 				  unsigned short ModeIdIndex,
-				  struct vb_device_info *);
+				  struct vb_device_info *pVBInfo);
 
 #endif
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging: xgifb: function definition argument should have an  identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-21 19:20 +0100
  Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition  argument should have an identifier name Julia Lawall <julia.lawall@lip6.fr> - 2017-02-21 19:20 +0100
  Re: [PATCH] staging: xgifb: function definition argument should have  an identifier name kbuild test robot <lkp@intel.com> - 2017-02-21 22:00 +0100

csiph-web