Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1585585 > unrolled thread
| Started by | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| First post | 2017-02-21 19:20 +0100 |
| Last post | 2017-02-21 22:00 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] staging: xgifb: function definition argument should have an identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-21 19:20 +0100
Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should have an identifier name Julia Lawall <julia.lawall@lip6.fr> - 2017-02-21 19:20 +0100
Re: [PATCH] staging: xgifb: function definition argument should have an identifier name kbuild test robot <lkp@intel.com> - 2017-02-21 22:00 +0100
| From | Arushi Singhal <arushisinghal19971997@gmail.com> |
|---|---|
| Date | 2017-02-21 19:20 +0100 |
| Subject | [PATCH] staging: xgifb: function definition argument should have an identifier name |
| Message-ID | <tdncB-6eZ-3@gated-at.bofh.it> |
function definition argument like 'struct vb_device_info *','unsigned long' etc. should have an identifier name. Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> --- drivers/staging/xgifb/vb_setmode.h | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h index 6f082a7a5a4a..e4cf9a633676 100644 --- a/drivers/staging/xgifb/vb_setmode.h +++ b/drivers/staging/xgifb/vb_setmode.h @@ -1,14 +1,15 @@ #ifndef _VBSETMODE_ #define _VBSETMODE_ -void InitTo330Pointer(unsigned char, struct vb_device_info *); -void XGI_UnLockCRT2(struct vb_device_info *); -void XGI_LockCRT2(struct vb_device_info *); -void XGI_DisplayOff(struct xgifb_video_info *, - struct xgi_hw_device_info *, - struct vb_device_info *); -void XGI_GetVBType(struct vb_device_info *); -void XGI_SenseCRT1(struct vb_device_info *); +void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo); +void XGI_UnLockCRT2(struct vb_device_info *pVBInfo); +void XGI_LockCRT2(struct vb_device_info *pVBInfo); +void XGI_DisplayOff(struct xgifb_video_info *xgifb_info, + struct xgi_hw_device_info *pXGIHWDE, + struct vb_device_info *pVBInfo); +void XGI_GetVBType(struct vb_device_info *pVBInfo); + pVBInfo->VBInfo = DisableCRT2Display; +void XGI_SenseCRT1(struct vb_device_info *pVBInfo); unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info, struct xgi_hw_device_info *HwDeviceExtension, unsigned short ModeNo); @@ -18,6 +19,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo, unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE, unsigned short ModeNo, unsigned short ModeIdIndex, - struct vb_device_info *); + struct vb_device_info *pVBInfo); #endif -- 2.11.0
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-02-21 19:20 +0100 |
| Subject | Re: [Outreachy kernel] [PATCH] staging: xgifb: function definition argument should have an identifier name |
| Message-ID | <tdncC-6eZ-19@gated-at.bofh.it> |
| In reply to | #1585585 |
On Tue, 21 Feb 2017, Arushi Singhal wrote: > function definition argument like 'struct vb_device_info *','unsigned > long' etc. should have an identifier name. > > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com> > --- > drivers/staging/xgifb/vb_setmode.h | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h > index 6f082a7a5a4a..e4cf9a633676 100644 > --- a/drivers/staging/xgifb/vb_setmode.h > +++ b/drivers/staging/xgifb/vb_setmode.h > @@ -1,14 +1,15 @@ > #ifndef _VBSETMODE_ > #define _VBSETMODE_ > > -void InitTo330Pointer(unsigned char, struct vb_device_info *); > -void XGI_UnLockCRT2(struct vb_device_info *); > -void XGI_LockCRT2(struct vb_device_info *); > -void XGI_DisplayOff(struct xgifb_video_info *, > - struct xgi_hw_device_info *, > - struct vb_device_info *); > -void XGI_GetVBType(struct vb_device_info *); > -void XGI_SenseCRT1(struct vb_device_info *); > +void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo); > +void XGI_UnLockCRT2(struct vb_device_info *pVBInfo); > +void XGI_LockCRT2(struct vb_device_info *pVBInfo); > +void XGI_DisplayOff(struct xgifb_video_info *xgifb_info, > + struct xgi_hw_device_info *pXGIHWDE, > + struct vb_device_info *pVBInfo); > +void XGI_GetVBType(struct vb_device_info *pVBInfo); > + pVBInfo->VBInfo = DisableCRT2Display; How does this like fit in? I don't think this would have successfully compiled. julia > +void XGI_SenseCRT1(struct vb_device_info *pVBInfo); > unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info, > struct xgi_hw_device_info *HwDeviceExtension, > unsigned short ModeNo); > @@ -18,6 +19,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo, > unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE, > unsigned short ModeNo, > unsigned short ModeIdIndex, > - struct vb_device_info *); > + struct vb_device_info *pVBInfo); > > #endif > -- > 2.11.0 > > -- > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com. > To post to this group, send email to outreachy-kernel@googlegroups.com. > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170221180852.GA19723%40arushi-HP-Pavilion-Notebook. > For more options, visit https://groups.google.com/d/optout. >
[toc] | [prev] | [next] | [standalone]
| From | kbuild test robot <lkp@intel.com> |
|---|---|
| Date | 2017-02-21 22:00 +0100 |
| Subject | Re: [PATCH] staging: xgifb: function definition argument should have an identifier name |
| Message-ID | <tdpHr-7P4-13@gated-at.bofh.it> |
| In reply to | #1585585 |
[Multipart message — attachments visible in raw view] — view raw
Hi Arushi,
[auto build test ERROR on v4.9-rc8]
[cannot apply to staging/staging-testing next-20170220]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Arushi-Singhal/staging-xgifb-function-definition-argument-should-have-an-identifier-name/20170222-031312
config: x86_64-randconfig-ne0-02220257 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from drivers/staging/xgifb/XGI_main_26.c:16:0:
>> drivers/staging/xgifb/vb_setmode.h:11:11: error: expected '=', ',', ';', 'asm' or '__attribute__' before '->' token
pVBInfo->VBInfo = DisableCRT2Display;
^~
vim +11 drivers/staging/xgifb/vb_setmode.h
5 void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
6 void XGI_LockCRT2(struct vb_device_info *pVBInfo);
7 void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
8 struct xgi_hw_device_info *pXGIHWDE,
9 struct vb_device_info *pVBInfo);
10 void XGI_GetVBType(struct vb_device_info *pVBInfo);
> 11 pVBInfo->VBInfo = DisableCRT2Display;
12 void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
13 unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
14 struct xgi_hw_device_info *HwDeviceExtension,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web