Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585494

Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Alexandre Belloni <alexandre.belloni@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver
Date Tue, 21 Feb 2017 17:30:02 +0100
Message-ID <tdlua-52u-17@gated-at.bofh.it> (permalink)
References <td2Uy-Zo-21@gated-at.bofh.it> <td3dU-16y-17@gated-at.bofh.it> <td5Sq-2NQ-15@gated-at.bofh.it> <td625-2RA-1@gated-at.bofh.it> <tddGi-8jR-17@gated-at.bofh.it> <tdfyp-161-3@gated-at.bofh.it> <tdfRM-1cI-3@gated-at.bofh.it> <tdguu-1L2-25@gated-at.bofh.it> <tdgNP-1UC-1@gated-at.bofh.it> <tdlaN-4Vr-13@gated-at.bofh.it>
X-Original-To Andy Shevchenko <andy.shevchenko@gmail.com>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent NeoMutt/20170113 (1.7.2)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 55
Organization linux.* mail to news gateway
X-Original-Cc Hans-Christian Egtvedt <egtvedt@samfundet.no>, Boris Brezillon <boris.brezillon@free-electrons.com>, Richard Weinberger <richard@nod.at>, "open list:MEMORY TECHNOLOGY..." <linux-mtd@lists.infradead.org>, Nicolas Ferre <nicolas.ferre@atmel.com>, Haavard Skinnemoen <hskinnemoen@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Wenyou Yang <wenyou.yang@atmel.com>, Josh Wu <rainyfeeling@outlook.com>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Cyrille Pitchen <cyrille.pitchen@atmel.com>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, devicetree <devicetree@vger.kernel.org>
X-Original-Date Tue, 21 Feb 2017 17:21:33 +0100
X-Original-Message-ID <20170221162133.jch6yzpotj4s7zob@piout.net>
X-Original-References <20170220213803.7ba5591e@bbrezillon> <20170220215009.0ecbf5a1@bbrezillon> <CAHp75VczsC9WdZWR9iCRh2JoNLFZyOtodrsDRYQoyaN7nkyf=A@mail.gmail.com> <CAHp75Vc_q-bEzA2-hVpHyR0GZ8mXxwJ8-UjECe31T04mb67q4w@mail.gmail.com> <20170221090610.6d531b94@bbrezillon> <CAHp75VfZfj-8ih3vg63w_dAq8xXE2Whu1bANXRcXS1_EGNq43A@mail.gmail.com> <20170221112641.6276c001@bbrezillon> <CAHp75Vcb9gtzF7LvH74JwL4dTUyQvKmg=dnTXKfjhVHuyK3WXg@mail.gmail.com> <20170221112720.ynehsryprhrhzjla@piout.net> <CAHp75VcKjYYAw8gw8yYXrd-vzZo50WOQ06AzPx+0g9Zakzjm-w@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1585494

Show key headers only | View raw

On 21/02/2017 at 18:09:09 +0200, Andy Shevchenko wrote:
> On Tue, Feb 21, 2017 at 1:27 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > (adding Hans-Christian)
> >
> > On 21/02/2017 at 13:02:21 +0200, Andy Shevchenko wrote:
> >> Abusing platform data with pointers is also not welcome.
> >>
> >> > (in this case, avr32).
> >>
> >> It's dead de facto.
> >>
> >> When last time did you compile kernel for it? What was the version of kernel?
> >> Did it get successfully?
> >>
> >
> > v4.10-rc3 was building successfully but had some issues in the network
> > code.
> 
> Newer kernel doesn't link...
> 
> >> When are we going to remove avr32 support from kernel completely?
> 
> > Ask that to the avr32 maintainers. It still builds and is still booted
> > by some people. And that actually seems to be you as you reported a bug
> > we introduced in 4.3. I don't think we had any other report after that.
> 
> https://patchwork.kernel.org/patch/9505727/
> 
> After that I gave up on it. Next time I will escalate directly to
> Linus. It's a complete necrophilia. I spent already enough time to
> look at that code. It brings now more burden than supports someone
> somewhere.
> 

As said, it builds fine without networking. Maybe the first step is to
ask the avr32 maintainers. If you already did so, please feel free to
send a patch to remove the whole architecture.
The benefits for atmel will be: proper big endian support, removal of
platform data from all the drivers, better clocksource handling.

> > It can be frustrating at times to handle that platform but if it is
> > working for someone, I don't see why we would remove it.
> 
> How it's working if it's not linked?
> 

Come on, v4.10 has just been release and v4.9 was building just fine. Do
you really expect everybody to closely follow linux-next or update
overnight?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] mtd: nand: Rework/cleanup the Atmel NAND driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 13:30 +0100
  [PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 13:30 +0100
  Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-20 21:30 +0100
    Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 21:40 +0100
      Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 22:00 +0100
        Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 00:50 +0100
          Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 01:00 +0100
            Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-21 09:10 +0100
              Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 11:10 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-21 11:30 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-02-21 11:50 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 12:10 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 12:30 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:10 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 17:30 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:40 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:50 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 18:20 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Håvard Skinnemoen <hskinnemoen@gmail.com> - 2017-02-24 06:20 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-24 09:30 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-24 10:00 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-24 10:40 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-24 11:00 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-24 12:50 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-02-24 11:10 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-02-24 10:40 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-24 10:30 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-02-24 10:40 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 18:10 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-21 12:30 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-02-21 14:50 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:00 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 17:20 +0100
                Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-21 15:00 +0100
  Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-02-21 14:10 +0100

csiph-web