Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1584967
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver |
| Date | 2017-02-21 01:00 +0100 |
| Message-ID | <td625-2RA-1@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tcVgm-4Bz-17@gated-at.bofh.it> <td2KR-VH-7@gated-at.bofh.it> <td2Uy-Zo-21@gated-at.bofh.it> <td3dU-16y-17@gated-at.bofh.it> <td5Sq-2NQ-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Feb 21, 2017 at 1:40 AM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Mon, Feb 20, 2017 at 10:50 PM, Boris Brezillon > <boris.brezillon@free-electrons.com> wrote: >> On Mon, 20 Feb 2017 21:38:03 +0100 >> Boris Brezillon <boris.brezillon@free-electrons.com> wrote: >> >>> On Mon, 20 Feb 2017 22:27:17 +0200 >>> Andy Shevchenko <andy.shevchenko@gmail.com> wrote: >>> >>> > On Mon, Feb 20, 2017 at 2:28 PM, Boris Brezillon >>> > <boris.brezillon@free-electrons.com> wrote: >>> > >>> > > drivers/mtd/nand/atmel/nand-controller.c | 2269 +++++++++++++++++++++++++++ >>> > > drivers/mtd/nand/atmel_nand.c | 2479 ------------------------------ >>> > >>> > Does -M -C help you? >>> > At least it would help reviewers >>> > >>> >>> No it doesn't, because files were not just moved around using git mv, >>> it's a complete rewrite of the driver. IIUC, you're about to review >>> this submission, or are you just trolling like last time? >> >> My bad, I mistaken you with someone else. Sorry for being harsh, but my >> explanation stands ;-). > > No problem. I was asking since it so big and on first glance looks > like a partial copy (I dunno if parameter to -C makes it somehow > useful), though I can't review this. It's too big to me. Sorry I'm > really not trolling, just didn't read commit message carefully. Okay, I very quickly looked into the code, what I noticed - you like extra parens and empty lines in some cases (not big deal) - some functions perhaps might have been refactored to have common pieces in error handling, though I didn't read core carefully. Most important part I have noticed is a GPIO request. I didn't get why you almost repeat gpiod_get() in case of platform data? Shouldn't we have GPIO look up table? Can we use builtin device properties (for GPIO and/or overall)? -- With Best Regards, Andy Shevchenko
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/3] mtd: nand: Rework/cleanup the Atmel NAND driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 13:30 +0100
[PATCH v2 3/3] mtd: nand: Remove unused chip->write_page() hook Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 13:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-20 21:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 21:40 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-20 22:00 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 00:50 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 01:00 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-21 09:10 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 11:10 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-21 11:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Nicolas Ferre <nicolas.ferre@atmel.com> - 2017-02-21 11:50 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 12:10 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 12:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:10 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 17:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:40 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:50 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 18:20 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Håvard Skinnemoen <hskinnemoen@gmail.com> - 2017-02-24 06:20 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-24 09:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-24 10:00 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-24 10:40 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-24 11:00 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-24 12:50 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-02-24 11:10 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-02-24 10:40 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-24 10:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Hans-Christian Noren Egtvedt <egtvedt@samfundet.no> - 2017-02-24 10:40 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 18:10 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-02-21 12:30 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-02-21 14:50 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-21 17:00 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-21 17:20 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-02-21 15:00 +0100
Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Nicolas Ferre <nicolas.ferre@microchip.com> - 2017-02-21 14:10 +0100
csiph-web