Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1586610
| Path | csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.szaf.org!news.unit0.net!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Yunlong Song <yunlong.song@huawei.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment |
| Date | Thu, 23 Feb 2017 03:20:01 +0100 |
| Message-ID | <tdRaF-2LC-5@gated-at.bofh.it> (permalink) |
| References | <tdEn8-1FE-25@gated-at.bofh.it> <tdEn8-1FE-27@gated-at.bofh.it> <tdQeB-27X-1@gated-at.bofh.it> |
| X-Original-To | Jaegeuk Kim <jaegeuk@kernel.org> |
| User-Agent | Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset="windows-1252" |
| Content-Transfer-Encoding | 7bit |
| X-Originating-IP | [10.111.74.205] |
| X-Cfilter-Loop | Reflected |
| X-Mirapoint-Virus-Rapid-Raw | score=unknown(0), refid=str=0001.0A090202.58AE4541.0012,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 |
| X-Mirapoint-Loop-ID | 4e26490d6013024d9cbff73de2a0b25b |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 61 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | <cm224.lee@samsung.com>, <yuchao0@huawei.com>, <chao@kernel.org>, <sylinux@163.com>, <miaoxie@huawei.com>, <bintian.wang@huawei.com>, <linux-fsdevel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net>, <linux-kernel@vger.kernel.org> |
| X-Original-Date | Thu, 23 Feb 2017 10:13:01 +0800 |
| X-Original-Message-ID | <58AE452D.60500@huawei.com> |
| X-Original-References | <1487767851-819-1-git-send-email-yunlong.song@huawei.com> <1487767851-819-3-git-send-email-yunlong.song@huawei.com> <20170223011754.GH4003@jaegeuk.local> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1586610 |
Show key headers only | View raw
Hi Jay,
But there are some differences:
1 Why not take "neighboring temperature" for ssr? For example, if type == CURSEG_COLD_DATA,
your new patch selects CURSEG_HOT_DATA first, how about select CURSEG_WARM_DATA first?
The patch I sent ensure this "neighboring temperature" for ssr.
2 Your new patch returns 0 for node ssr, does get_ssr_segment work only for data?
3 I see your new patch just "continue" when i == type, why not consider the current type?
On 2017/2/23 9:17, Jaegeuk Kim wrote:
> Hi Yunlong,
>
> I've been testing the similar patches as I attached.
>
> Thanks,
>
> On 02/22, Yunlong Song wrote:
>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>> ---
>> fs/f2fs/segment.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>> index 9d13743..5fe71b9 100644
>> --- a/fs/f2fs/segment.c
>> +++ b/fs/f2fs/segment.c
>> @@ -1540,12 +1540,17 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>> {
>> struct curseg_info *curseg = CURSEG_I(sbi, type);
>> const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
>> + int old_type = type;
>>
>> if (IS_NODESEG(type)) {
>> for (; type >= CURSEG_HOT_NODE; type--)
>> if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> BG_GC, type, SSR))
>> return 1;
>> + for (type = old_type + 1; type <= CURSEG_COLD_NODE; type++)
>> + if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> + BG_GC, type, SSR))
>> + return 1;
>> return 0;
>> }
>>
>> @@ -1554,6 +1559,10 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>> if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> BG_GC, type, SSR))
>> return 1;
>> + for (type = old_type + 1; type <= CURSEG_COLD_DATA; type++)
>> + if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>> + BG_GC, type, SSR))
>> + return 1;
>> return 0;
>> }
>>
>> --
>> 1.8.5.2
--
Thanks,
Yunlong Song
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] f2fs: clean up codes in get_ssr_segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-22 13:40 +0100
[PATCH 2/3] f2fs: provide more chance to get node ssr Yunlong Song <yunlong.song@huawei.com> - 2017-02-22 13:40 +0100
[PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-22 13:40 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 02:20 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-23 03:20 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-23 03:50 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Chao Yu <yuchao0@huawei.com> - 2017-02-24 10:10 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 10:30 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Chao Yu <yuchao0@huawei.com> - 2017-02-24 11:50 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 12:50 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-24 19:00 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-24 21:10 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-25 03:20 +0100
Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 01:50 +0100
Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 02:10 +0100
Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-23 03:00 +0100
csiph-web