Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1587455
| From | Yunlong Song <yunlong.song@huawei.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment |
| Date | 2017-02-24 10:30 +0100 |
| Message-ID | <tekmm-6zZ-5@gated-at.bofh.it> (permalink) |
| References | <tdEn8-1FE-25@gated-at.bofh.it> <tdEn8-1FE-27@gated-at.bofh.it> <tdQeB-27X-1@gated-at.bofh.it> <tek2Z-6t4-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Jaegeuk and Chao,
How about the question I pointed out in last mail:
Why not take "neighboring temperature" for ssr? For example, if type == CURSEG_COLD_DATA,
the new patch selects CURSEG_HOT_DATA first, why not select CURSEG_WARM_DATA first?
The patch I sent ensure this "neighboring temperature" for ssr. This is to reduce the influence of
mixing different levels of hot/code node types.
On 2017/2/24 17:05, Chao Yu wrote:
> Hi Jaegeuk,
>
> Reviewed-by: Chao Yu <yuchao0@huawei.com>
>
> For your attached two patches.
>
> Thanks,
>
> On 2017/2/23 9:17, Jaegeuk Kim wrote:
>> Hi Yunlong,
>>
>> I've been testing the similar patches as I attached.
>>
>> Thanks,
>>
>> On 02/22, Yunlong Song wrote:
>>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>>> ---
>>> fs/f2fs/segment.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
>>> index 9d13743..5fe71b9 100644
>>> --- a/fs/f2fs/segment.c
>>> +++ b/fs/f2fs/segment.c
>>> @@ -1540,12 +1540,17 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>>> {
>>> struct curseg_info *curseg = CURSEG_I(sbi, type);
>>> const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
>>> + int old_type = type;
>>>
>>> if (IS_NODESEG(type)) {
>>> for (; type >= CURSEG_HOT_NODE; type--)
>>> if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>> BG_GC, type, SSR))
>>> return 1;
>>> + for (type = old_type + 1; type <= CURSEG_COLD_NODE; type++)
>>> + if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>> + BG_GC, type, SSR))
>>> + return 1;
>>> return 0;
>>> }
>>>
>>> @@ -1554,6 +1559,10 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>>> if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>> BG_GC, type, SSR))
>>> return 1;
>>> + for (type = old_type + 1; type <= CURSEG_COLD_DATA; type++)
>>> + if (v_ops->get_victim(sbi, &(curseg)->next_segno,
>>> + BG_GC, type, SSR))
>>> + return 1;
>>> return 0;
>>> }
>>>
>>> --
>>> 1.8.5.2
>
> .
>
--
Thanks,
Yunlong Song
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/3] f2fs: clean up codes in get_ssr_segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-22 13:40 +0100
[PATCH 2/3] f2fs: provide more chance to get node ssr Yunlong Song <yunlong.song@huawei.com> - 2017-02-22 13:40 +0100
[PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-22 13:40 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 02:20 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-23 03:20 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-23 03:50 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Chao Yu <yuchao0@huawei.com> - 2017-02-24 10:10 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 10:30 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Chao Yu <yuchao0@huawei.com> - 2017-02-24 11:50 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-24 12:50 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-24 19:00 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-24 21:10 +0100
Re: [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-25 03:20 +0100
Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 01:50 +0100
Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Jaegeuk Kim <jaegeuk@kernel.org> - 2017-02-23 02:10 +0100
Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Yunlong Song <yunlong.song@huawei.com> - 2017-02-23 03:00 +0100
csiph-web