Re: [PATCH] uapi: fix linux/if.h userspace compilation errors

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] uapi: fix linux/if.h userspace compilation errors
Date	2017-02-22 22:20 +0100
Message-ID	<tdMun-7Lo-27@gated-at.bofh.it> (permalink)
References	<tcUNj-4c0-5@gated-at.bofh.it> <tdmgx-5z4-9@gated-at.bofh.it> <tdp4K-7un-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Tue, 21 Feb 2017 23:19:14 +0300

> On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote:
>> From: "Dmitry V. Levin" <ldv@altlinux.org>
>> Date: Mon, 20 Feb 2017 14:58:41 +0300
>> 
>> > Include <sys/socket.h> (guarded by ifndef __KERNEL__) to fix
>> > the following linux/if.h userspace compilation errors:
>> 
>> Wouldn't it be so much better to do this in include/uapi/linux/socket.h?
> 
> Yes, it would be nicer if we could afford it.  However, changing
> uapi/linux/socket.h to include <sys/socket.h> is less conservative than
> changing every uapi header that fails to compile because of its use
> of struct sockaddr.  It's risky because <sys/socket.h> pulls in other
> types that might conflict with definitions provided by uapi headers.

Ok, I'll apply this for now.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] uapi: fix linux/if.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-20 13:00 +0100
  Re: [PATCH] uapi: fix linux/if.h userspace compilation errors David Miller <davem@davemloft.net> - 2017-02-21 18:20 +0100
    Re: [PATCH] uapi: fix linux/if.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-21 21:20 +0100
      Re: [PATCH] uapi: fix linux/if.h userspace compilation errors "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-22 03:30 +0100
        [PATCH 1/2] uapi: add a compatibility layer between linux/time.h and glibc "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-22 03:30 +0100
        [PATCH 2/2] uapi: add a compatibility layer between linux/uio.h and glibc "Dmitry V. Levin" <ldv@altlinux.org> - 2017-02-22 03:40 +0100
      Re: [PATCH] uapi: fix linux/if.h userspace compilation errors David Miller <davem@davemloft.net> - 2017-02-22 22:20 +0100

csiph-web