Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586315

Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state

Show all headers | View raw

On 02/21, bsegall@google.com wrote:
>
> In PT_SEIZED + LISTEN mode SIGSTOP/SIGCONT signals cause a wakeup
> against __TASK_TRACED. If this races with the ptrace_unfreeze_traced at
> the end of a PTRACE_LISTEN, this can wake the task /after/ the check
> against __TASK_TRACED, but before the reset of state to TASK_TRACED.

Oh, thanks...

note also that PTRACE_LISTEN itself can do ptrace_signal_wake_up(true),

> This causes it to instead clobber TASK_WAKING,

even if it is already TASK_RUNNING it is simply wrong to set TASK_TRACED
in both cases, right?

Thanks. The patch looks good at first glance, but let me think a bit...
perhaps we should change PTRACE_LISTEN instead, not sure.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state bsegall@google.com - 2017-02-21 19:50 +0100
  Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state Oleg Nesterov <oleg@redhat.com> - 2017-02-22 18:00 +0100
    Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state Oleg Nesterov <oleg@redhat.com> - 2017-02-22 18:20 +0100
    Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state bsegall@google.com - 2017-02-22 19:00 +0100
  Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state Oleg Nesterov <oleg@redhat.com> - 2017-02-24 17:40 +0100
    Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state bsegall@google.com - 2017-02-27 19:10 +0100

csiph-web