Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586322

Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state

From Oleg Nesterov <oleg@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state
Date 2017-02-22 18:20 +0100
Message-ID <tdIK5-53Y-7@gated-at.bofh.it> (permalink)
References <tdnFE-6qe-11@gated-at.bofh.it> <tdIqK-4Fw-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 02/22, Oleg Nesterov wrote:
>
> note also that PTRACE_LISTEN itself can do ptrace_signal_wake_up(true),

please ignore, in this case the __TASK_TRACED at the start of _unfreeze()
saves us.

> 
> > This causes it to instead clobber TASK_WAKING,
> 
> even if it is already TASK_RUNNING it is simply wrong to set TASK_TRACED
> in both cases, right?
> 
> Thanks. The patch looks good at first glance, but let me think a bit...
> perhaps we should change PTRACE_LISTEN instead, not sure.
> 
> Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state bsegall@google.com - 2017-02-21 19:50 +0100
  Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state Oleg Nesterov <oleg@redhat.com> - 2017-02-22 18:00 +0100
    Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state Oleg Nesterov <oleg@redhat.com> - 2017-02-22 18:20 +0100
    Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state bsegall@google.com - 2017-02-22 19:00 +0100
  Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state Oleg Nesterov <oleg@redhat.com> - 2017-02-24 17:40 +0100
    Re: [PATCH] ptrace: fix PTRACE_LISTEN race corrupting task->state bsegall@google.com - 2017-02-27 19:10 +0100

csiph-web