Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586070

[PATCH] staging: xgifb: function prototype argument should have an identifier name

Path csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From Arushi Singhal <arushisinghal19971997@gmail.com>
Newsgroups linux.kernel
Subject [PATCH] staging: xgifb: function prototype argument should have an identifier name
Date Wed, 22 Feb 2017 12:20:02 +0100
Message-ID <tdD7I-R8-7@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=wDyM6TO8tbSTxYFqN6MWE7rf1gaXwIYGmjqCJ0zSJhM=; b=LcBWXm7Ts+986a8BWCH2ER6QBBQEihyZRaCw0/8a6Hen1g1IYafC9ZdLz7gIMqQtZ7 SpDkjIKcxh9zG6SQIimrOqvvowaCKGinO8EjBOVnOZgxuRgOTSvmm+Dj2Zc6bd3ByIyB vuSSodh34xOCuriFMdlAntXM9vADfkpEI8WsYVYPUDNno47P7QcLR7sRhmjtno2u3HID nmKPQWtGgjGngppW/PLR7duIRE5oeVzgYAaYhkB/MIX/28DZb+ke/6XUMVpjdutHjMeV UTYamD/uvXsQ9VRQneR2Xc7Sj1QWT1jRg53QMmA/ki4936Ebl/eKRleDNtpxTpBR/cuV NC1Q==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=wDyM6TO8tbSTxYFqN6MWE7rf1gaXwIYGmjqCJ0zSJhM=; b=Gok3FLZ8Q9+jM73PXybtEl9hZnsWoTIv/GnAbi6hUy6+9XHWuDzF0KOmCEg8BwM2/X QuJec+WjZNnf0dS5/2vrfh1lFUY3lqnRjm0RY3rksjk1jvBHpqxDgjFVdrEGgqxz7Xaj uKR3cUtHJZ5z94LYOoyZz5FE/H+zKGCnvDpMi0KX6KJ5GUahxvsUjxX3soiJo1fqC/sA HCJ6YOyJ/VX5h/QPS/k8UitdTnsGLEqg2vXw/TT6gWMIuKdb5PRFvOcl91xqDR21T6fs bvdCfoOVczgRgcZvhyQOnpkM4J68vUX8v/M9P7N56WuAr/h3YfMhqllNSssVvv6CzsnP HV1g==
X-Gm-Message-State AMke39mAeLkWjMaZaiFVVDUPtpyivPlbP9B4BfVCF7LHO8U3FwLmNzpdlqsC5y694vealw==
X-Received by 10.99.110.74 with SMTP id j71mr40656376pgc.134.1487762363829; Wed, 22 Feb 2017 03:19:23 -0800 (PST)
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 51
Organization linux.* mail to news gateway
X-Original-Cc Greg Kroah-Hartman <gregkh@linuxfoundation.org>, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
X-Original-Date Wed, 22 Feb 2017 16:49:19 +0530
X-Original-Message-ID <20170222111918.GA25063@arushi-HP-Pavilion-Notebook>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1586070

Show key headers only | View raw

function prototype arguments like 'struct vb_device_info *','unsigned
long' etc. should have an identifier name.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
Changes in v3:
  - By mistake one irrelevant line was added which is removed in this
    patch.
  - write the changes done in previous version in correct format.
  - make the commit subject more relevant and accurate.
---
 drivers/staging/xgifb/vb_setmode.h | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/xgifb/vb_setmode.h b/drivers/staging/xgifb/vb_setmode.h
index 6f082a7a5a4a..c6317ab00474 100644
--- a/drivers/staging/xgifb/vb_setmode.h
+++ b/drivers/staging/xgifb/vb_setmode.h
@@ -1,14 +1,14 @@
 #ifndef _VBSETMODE_
 #define _VBSETMODE_
 
-void InitTo330Pointer(unsigned char, struct vb_device_info *);
-void XGI_UnLockCRT2(struct vb_device_info *);
-void XGI_LockCRT2(struct vb_device_info *);
-void XGI_DisplayOff(struct xgifb_video_info *,
-		    struct xgi_hw_device_info *,
-		    struct vb_device_info *);
-void XGI_GetVBType(struct vb_device_info *);
-void XGI_SenseCRT1(struct vb_device_info *);
+void InitTo330Pointer(unsigned char ChipType, struct vb_device_info *pVBInfo);
+void XGI_UnLockCRT2(struct vb_device_info *pVBInfo);
+void XGI_LockCRT2(struct vb_device_info *pVBInfo);
+void XGI_DisplayOff(struct xgifb_video_info *xgifb_info,
+		    struct xgi_hw_device_info *pXGIHWDE,
+		    struct vb_device_info *pVBInfo);
+void XGI_GetVBType(struct vb_device_info *pVBInfo);
+void XGI_SenseCRT1(struct vb_device_info *pVBInfo);
 unsigned char XGISetModeNew(struct xgifb_video_info *xgifb_info,
 			    struct xgi_hw_device_info *HwDeviceExtension,
 			    unsigned short ModeNo);
@@ -18,6 +18,6 @@ unsigned char XGI_SearchModeID(unsigned short ModeNo,
 unsigned short XGI_GetRatePtrCRT2(struct xgi_hw_device_info *pXGIHWDE,
 				  unsigned short ModeNo,
 				  unsigned short ModeIdIndex,
-				  struct vb_device_info *);
+				  struct vb_device_info *pVBInfo);
 
 #endif
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: xgifb: function prototype argument should have an  identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-22 12:20 +0100
  Re: [PATCH] staging: xgifb: function prototype argument should have  an identifier name Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-24 17:40 +0100
    Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype  argument should have an identifier name Julia Lawall <julia.lawall@lip6.fr> - 2017-02-24 17:50 +0100
      Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype  argument should have an identifier name Julia Lawall <julia.lawall@lip6.fr> - 2017-02-25 07:40 +0100

csiph-web