Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1588074

Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name

From Julia Lawall <julia.lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype argument should have an identifier name
Date 2017-02-25 07:40 +0100
Message-ID <teEbo-3P4-7@gated-at.bofh.it> (permalink)
References <tdD7I-R8-7@gated-at.bofh.it> <ter4u-2Kh-17@gated-at.bofh.it> <tere9-2Ov-17@gated-at.bofh.it> <tere9-2Ov-15@gated-at.bofh.it> <teEbo-3P4-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sat, 25 Feb 2017, Arushi Singhal wrote:

>
>
> On Fri, Feb 24, 2017 at 10:18 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
>
>       On Fri, 24 Feb 2017, Arushi Singhal wrote:
>
>       >
>       >
>       > On Fri, Feb 24, 2017 at 10:01 PM, Greg Kroah-Hartman
>       > <gregkh@linuxfoundation.org> wrote:
>       >       On Wed, Feb 22, 2017 at 04:49:19PM +0530, Arushi Singhal
>       wrote:
>       >       > function prototype arguments like 'struct
>       vb_device_info
>       >       *','unsigned
>       >       > long' etc. should have an identifier name.
>       >       >
>       >       > Signed-off-by: Arushi Singhal
>       >       <arushisinghal19971997@gmail.com>
>       >       > ---
>       >       > Changes in v3:
>       >       >   - By mistake one irrelevant line was added which is
>       removed
>       >       in this
>       >       >     patch.
>       >       >   - write the changes done in previous version in
>       correct
>       >       format.
>       >       >   - make the commit subject more relevant and
>       accurate.
>       >
>       >       This patch doesn't apply to my tree at all :(
>       >
>       > Why this is so?
>
>       Maybe someone else made a change on the same lines as yours. 
>       Check that
>       your tree is up to date.
>
> Is all the changes being done by someone before?

I don't know.  Just update your tree and try to apply your patch again.
Or look at the code that your patch should apply to.  It should be easy to
see what is wrong.

julia

>
>       julia
>
>       > thanks
>       > Arushi
>       >       sorry,
>       >
>       >       greg k-h
>       >
>       >
> > --
> > You received this message because you are subscribed to the Google
> Groups
> > "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it,
> send an
> > email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to
> outreachy-kernel@googlegroups.com.
> > To view this discussion on the webvisithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF_sihk6_Uhg
> LzUH6
> > FVSFMu02Vadp1tjatQft-UJ14SJeA%40mail.gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
> >
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF91bd_er%2BidvUB
> PZCTYFHaxF6Mgf1oQ6vTz9gmk6ggC6Q%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] staging: xgifb: function prototype argument should have an  identifier name Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-02-22 12:20 +0100
  Re: [PATCH] staging: xgifb: function prototype argument should have  an identifier name Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-02-24 17:40 +0100
    Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype  argument should have an identifier name Julia Lawall <julia.lawall@lip6.fr> - 2017-02-24 17:50 +0100
      Re: [Outreachy kernel] Re: [PATCH] staging: xgifb: function prototype  argument should have an identifier name Julia Lawall <julia.lawall@lip6.fr> - 2017-02-25 07:40 +0100

csiph-web