Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1585995
| From | Chunfeng Yun <chunfeng.yun@mediatek.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 1/8] phy: phy-mt65xx-usb3: improve RX detection stable time |
| Date | 2017-02-22 10:00 +0100 |
| Message-ID | <tdAWd-7u3-3@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The default value of RX detection stable time is 10us, and this margin is too big for some critical cases which cause U3 link fail and link to U2(probability is about 1%). So change it to 5us. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> --- drivers/phy/phy-mt65xx-usb3.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/phy/phy-mt65xx-usb3.c b/drivers/phy/phy-mt65xx-usb3.c index d972067..fe2392a 100644 --- a/drivers/phy/phy-mt65xx-usb3.c +++ b/drivers/phy/phy-mt65xx-usb3.c @@ -112,6 +112,14 @@ #define P3D_RG_CDR_BIR_LTD0 GENMASK(12, 8) #define P3D_RG_CDR_BIR_LTD0_VAL(x) ((0x1f & (x)) << 8) +#define U3P_U3_PHYD_RXDET1 (SSUSB_SIFSLV_U3PHYD_BASE + 0x128) +#define P3D_RG_RXDET_STB2_SET GENMASK(17, 9) +#define P3D_RG_RXDET_STB2_SET_VAL(x) ((0x1ff & (x)) << 9) + +#define U3P_U3_PHYD_RXDET2 (SSUSB_SIFSLV_U3PHYD_BASE + 0x12c) +#define P3D_RG_RXDET_STB2_SET_P3 GENMASK(8, 0) +#define P3D_RG_RXDET_STB2_SET_P3_VAL(x) (0x1ff & (x)) + #define U3P_XTALCTL3 (SSUSB_SIFSLV_SPLLC + 0x0018) #define XC3_RG_U3_XTAL_RX_PWD BIT(9) #define XC3_RG_U3_FRC_XTAL_RX_PWD BIT(8) @@ -295,6 +303,16 @@ static void phy_instance_init(struct mt65xx_u3phy *u3phy, tmp |= P3D_RG_CDR_BIR_LTD0_VAL(0xc) | P3D_RG_CDR_BIR_LTD1_VAL(0x3); writel(tmp, port_base + U3P_PHYD_CDR1); + tmp = readl(port_base + U3P_U3_PHYD_RXDET1); + tmp &= ~P3D_RG_RXDET_STB2_SET; + tmp |= P3D_RG_RXDET_STB2_SET_VAL(0x10); + writel(tmp, port_base + U3P_U3_PHYD_RXDET1); + + tmp = readl(port_base + U3P_U3_PHYD_RXDET2); + tmp &= ~P3D_RG_RXDET_STB2_SET_P3; + tmp |= P3D_RG_RXDET_STB2_SET_P3_VAL(0x10); + writel(tmp, port_base + U3P_U3_PHYD_RXDET2); + dev_dbg(u3phy->dev, "%s(%d)\n", __func__, index); } -- 1.7.9.5
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH v3 1/8] phy: phy-mt65xx-usb3: improve RX detection stable time Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-02-22 10:00 +0100
[PATCH v3 5/8] phy: phy-mt65xx-usb3: add support for new version phy Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-02-22 10:00 +0100
[PATCH v3 8/8] dt-bindings: phy-mt65xx-usb: add support for new version phy Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-02-22 10:00 +0100
Re: [PATCH v3 8/8] dt-bindings: phy-mt65xx-usb: add support for new version phy Rob Herring <robh@kernel.org> - 2017-02-27 23:40 +0100
[PATCH v3 2/8] phy: phy-mt65xx-usb3: increase LFPS filter threshold Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-02-22 10:00 +0100
[PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-02-22 10:00 +0100
Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2017-02-22 10:40 +0100
Re: [PATCH v3 7/8] arm64: dts: mt8173: move clock from phy node into port nodes Chunfeng Yun <chunfeng.yun@mediatek.com> - 2017-02-22 11:50 +0100
csiph-web