Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support

From	Jonathan Cameron <jic23@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support
Date	2017-02-19 14:20 +0100
Message-ID	<tczzc-7PQ-9@gated-at.bofh.it> (permalink)
References	<tbraF-4Hb-3@gated-at.bofh.it> <tbraG-4Hb-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16/02/17 10:02, Eva Rachel Retuya wrote:
> Add SPI driver for initializing spi regmap for the adxl345 core driver.
> The driver supports the same functionality as I2C namely the x, y, z and
> scale readings.
> 
> Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com>
Looks nice.  I didn't know about the readmask stuff in regmap so 
always good to see something new.

Jonathan
> ---
>  drivers/iio/accel/Kconfig       | 13 +++++++
>  drivers/iio/accel/Makefile      |  1 +
>  drivers/iio/accel/adxl345_spi.c | 75 +++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 89 insertions(+)
>  create mode 100644 drivers/iio/accel/adxl345_spi.c
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 5bdd87f..d474fed 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -21,6 +21,19 @@ config ADXL345_I2C
>  	  To compile this driver as a module, choose M here: the
>  	  module will be called adxl345_i2c.
>  
> +config ADXL345_SPI
> +	tristate "Analog Devices ADXL345 3-Axis Digital Accelerometer SPI Driver"
> +	depends on !(INPUT_ADXL34X=y || INPUT_ADXL34X=m)
> +	depends on SPI
> +	select ADXL345
> +	select REGMAP_SPI
> +	help
> +	  Say Y here if you want to build support for the Analog Devices
> +	  ADXL345 3-axis digital accelerometer.
> +
> +	  To compile this driver as a module, choose M here: the
> +	  module will be called adxl345_spi.
> +
>  config BMA180
>  	tristate "Bosch BMA180/BMA250 3-Axis Accelerometer Driver"
>  	depends on I2C
> diff --git a/drivers/iio/accel/Makefile b/drivers/iio/accel/Makefile
> index 3f4a6d6..31fba19 100644
> --- a/drivers/iio/accel/Makefile
> +++ b/drivers/iio/accel/Makefile
> @@ -5,6 +5,7 @@
>  # When adding new entries keep the list in alphabetical order
>  obj-$(CONFIG_ADXL345) += adxl345_core.o
>  obj-$(CONFIG_ADXL345_I2C) += adxl345_i2c.o
> +obj-$(CONFIG_ADXL345_SPI) += adxl345_spi.o
>  obj-$(CONFIG_BMA180) += bma180.o
>  obj-$(CONFIG_BMA220) += bma220_spi.o
>  obj-$(CONFIG_BMC150_ACCEL) += bmc150-accel-core.o
> diff --git a/drivers/iio/accel/adxl345_spi.c b/drivers/iio/accel/adxl345_spi.c
> new file mode 100644
> index 0000000..5fcd1fa
> --- /dev/null
> +++ b/drivers/iio/accel/adxl345_spi.c
> @@ -0,0 +1,75 @@
> +/*
> + * ADXL345 3-Axis Digital Accelerometer
> + *
> + * Copyright (c) 2017 Eva Rachel Retuya <eraretuya@gmail.com>
> + *
> + * This file is subject to the terms and conditions of version 2 of
> + * the GNU General Public License. See the file COPYING in the main
> + * directory of this archive for more details.
> + *
> + * SPI driver for ADXL345
> + */
> +
> +#include <linux/module.h>
> +#include <linux/regmap.h>
> +#include <linux/spi/spi.h>
> +
> +#include "adxl345.h"
> +
> +#define ADXL345_MAX_SPI_FREQ_HZ		5000000
> +
> +static const struct regmap_config adxl345_spi_regmap_config = {
> +	.reg_bits = 8,
> +	.val_bits = 8,
> +	 /* Setting bits 7 and 6 enables multiple-byte read */
> +	.read_flag_mask = BIT(7) | BIT(6),
Nice. I didn't know about that one ;)
> +};
> +
> +static int adxl345_spi_probe(struct spi_device *spi)
> +{
> +	struct regmap *regmap;
> +	const struct spi_device_id *id = spi_get_device_id(spi);
> +
> +	/* Bail out if max_speed_hz exceeds 5 MHz */
> +	if (spi->max_speed_hz > ADXL345_MAX_SPI_FREQ_HZ) {
> +		dev_err(&spi->dev, "SPI CLK, %d Hz exceeds 5 MHz\n",
> +			spi->max_speed_hz);
> +		return -EINVAL;
> +	}
> +
> +	regmap = devm_regmap_init_spi(spi, &adxl345_spi_regmap_config);
> +	if (IS_ERR(regmap)) {
> +		dev_err(&spi->dev, "Error initializing spi regmap: %d\n",
> +			(int)PTR_ERR(regmap));
> +		return PTR_ERR(regmap);
> +	}
> +
> +	return adxl345_common_probe(&spi->dev, regmap, id->name);
> +}
> +
> +static int adxl345_spi_remove(struct spi_device *spi)
> +{
> +	return adxl345_common_remove(&spi->dev);
> +}
> +
> +static const struct spi_device_id adxl345_spi_id[] = {
> +	{ "adxl345", 0 },
> +	{ }
> +};
> +
> +MODULE_DEVICE_TABLE(spi, adxl345_spi_id);
> +
> +static struct spi_driver adxl345_spi_driver = {
> +	.driver = {
> +		.name	= "adxl345_spi",
> +	},
> +	.probe		= adxl345_spi_probe,
> +	.remove		= adxl345_spi_remove,
> +	.id_table	= adxl345_spi_id,
> +};
> +
> +module_spi_driver(adxl345_spi_driver);
> +
> +MODULE_AUTHOR("Eva Rachel Retuya <eraretuya@gmail.com>");
> +MODULE_DESCRIPTION("ADXL345 3-Axis Digital Accelerometer SPI driver");
> +MODULE_LICENSE("GPL v2");
>

Thread

[PATCH 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
  [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Lars-Peter Clausen <lars@metafoo.de> - 2017-02-19 11:10 +0100
      Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-19 13:20 +0100
        Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Lars-Peter Clausen <lars@metafoo.de> - 2017-02-20 13:10 +0100
          Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-21 16:20 +0100
  [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Jonathan Cameron <jic23@kernel.org> - 2017-02-19 14:20 +0100
      Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-20 07:50 +0100
        Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-20 10:50 +0100
          Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-20 13:00 +0100
  [PATCH 3/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support Jonathan Cameron <jic23@kernel.org> - 2017-02-19 14:20 +0100
      Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-20 07:50 +0100
  [PATCH 1/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 1/4] iio: accel: adxl345: Use I2C regmap instead of direct  I2C access Jonathan Cameron <jic23@kernel.org> - 2017-02-19 14:10 +0100

csiph-web