Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C
Date	2017-02-20 13:00 +0100
Message-ID	<tcUNj-4c0-3@gated-at.bofh.it> (permalink)
References	<tbraF-4Hb-3@gated-at.bofh.it> <tbraF-4Hb-5@gated-at.bofh.it> <tczzc-7PQ-5@gated-at.bofh.it> <tcPXj-1ay-9@gated-at.bofh.it> <tcSLw-2W4-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 20, 2017 at 11:32 AM, Eva Rachel Retuya <eraretuya@gmail.com> wrote:
> On Mon, Feb 20, 2017 at 02:41:12PM +0800, Eva Rachel Retuya wrote:
>> On Sun, Feb 19, 2017 at 01:11:29PM +0000, Jonathan Cameron wrote:
>> > On 16/02/17 10:02, Eva Rachel Retuya wrote:

>> Hello Jonathan,
>>
>> Thanks for the feedback. I amended the relevant commits as you say and
>> git detects the file adxl345.c -> adxl345_core.c as 78% renamed. The
>> reason for that percentage is that I did some probe/remove renames and
>> some other deletions here and there. Should I commit them separately in
>> order to get the move detection to work?
>>
>
> Moved the deletions/modifications into patch 1. I hope I got it right
> this time?

I'm not a Jonathan, but there my remarks.

1. Yes, this version looks better.
2. Just a hint: check -M (for move) and -C (for copy) parameters to
git format-patch.
3. And please avoid over quoting when answering mails.

Thanks.

-- 
With Best Regards,
Andy Shevchenko

Thread

[PATCH 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
  [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Lars-Peter Clausen <lars@metafoo.de> - 2017-02-19 11:10 +0100
      Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-19 13:20 +0100
        Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Lars-Peter Clausen <lars@metafoo.de> - 2017-02-20 13:10 +0100
          Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-21 16:20 +0100
  [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Jonathan Cameron <jic23@kernel.org> - 2017-02-19 14:20 +0100
      Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-20 07:50 +0100
        Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-20 10:50 +0100
          Re: [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-02-20 13:00 +0100
  [PATCH 3/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support Jonathan Cameron <jic23@kernel.org> - 2017-02-19 14:20 +0100
      Re: [PATCH 3/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-20 07:50 +0100
  [PATCH 1/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access Eva Rachel Retuya <eraretuya@gmail.com> - 2017-02-16 11:10 +0100
    Re: [PATCH 1/4] iio: accel: adxl345: Use I2C regmap instead of direct  I2C access Jonathan Cameron <jic23@kernel.org> - 2017-02-19 14:10 +0100

csiph-web