Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when watchdog is disabled

From	Guenter Roeck <linux@roeck-us.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when watchdog is disabled
Date	2017-02-20 05:50 +0100
Message-ID	<tcO5b-8mA-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <tbA4h-2sg-7@gated-at.bofh.it> <tbS1c-5xl-45@gated-at.bofh.it> <tbSue-5X8-15@gated-at.bofh.it> <tcDCO-1MT-25@gated-at.bofh.it> <tcJyx-5on-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/19/2017 03:52 PM, Alexandre Belloni wrote:
> On 19/02/2017 at 08:57:35 -0800, Guenter Roeck wrote:
>>>> That means if the watchdog is running, the timeout would not be updated.
>>>> It should be updated no matter if it is running or not.
>>>>
>>>
>>> No, it is enabling the watchdog, then changing WDV and WDD and finally
>>> disabling the watchdog if necessary. So, WDV and WDD are always changed.
>>>
>> You are correct. Sorry for the noise.
>>
>> Seems odd that the watchdog must be _running_ to change the timeout.
>> Usually, if there is a restriction, it is the opposite. I hope this
>> doesn't cause race conditions, where the watchdog fires immediately
>> after being enabled due to a low timeout.
>>
>
> While it is difficult to reproduce, I can confirm it races and sometimes
> reset the SoC without any good reason. It doesn't matter whether it is
> disabled or not
>

Outch :-(.

> I've raised the issue at Atmel last Thursday so I don't have any answer
> yet.
>

Please keep us in the loop.

Thanks,
Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when watchdog is disabled Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-16 20:40 +0100
  Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when  watchdog is disabled Guenter Roeck <linux@roeck-us.net> - 2017-02-17 15:50 +0100
    Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when  watchdog is disabled Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-17 16:20 +0100
      Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when  watchdog is disabled Guenter Roeck <linux@roeck-us.net> - 2017-02-19 18:40 +0100
        Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when  watchdog is disabled Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-02-20 01:00 +0100
          Re: [PATCH v2 2/3] watchdog: sama5d4: Fix setting timeout when  watchdog is disabled Guenter Roeck <linux@roeck-us.net> - 2017-02-20 05:50 +0100

csiph-web