Re: [PATCH] IB/hns: include linux/module.h

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/hns: include linux/module.h
Date	2017-02-19 15:00 +0100
Message-ID	<tcAbT-83c-9@gated-at.bofh.it> (permalink)
References	<tbS1b-5xl-11@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, 2017-02-17 at 15:38 +0100, Arnd Bergmann wrote:
> I ran into a build error on arm64 randconfig testing:
> 
> infiniband/hw/hns/hns_roce_main.c:539:1: error: data definition has
> no type or storage class [-Werror]
> infiniband/hw/hns/hns_roce_main.c:539:1: error: type defaults to
> 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> infiniband/hw/hns/hns_roce_main.c:539:1: error: parameter names
> (without types) in function declaration [-Werror]
> infiniband/hw/hns/hns_roce_main.c:979:226: error: data definition has
> no type or storage class [-Werror]
> infiniband/hw/hns/hns_roce_main.c:979:226: error: type defaults to
> 'int' in declaration of 'module_init' [-Werror=implicit-int]
> infiniband/hw/hns/hns_roce_main.c:979:1: error: parameter names
> (without types) in function declaration [-Werror]
> 
> Including the module.h makes it build again.
> 
> Fixes: 9a4435375cd1 ("IB/hns: Add driver files for hns RoCE driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/hns: include linux/module.h Arnd Bergmann <arnd@arndb.de> - 2017-02-17 15:50 +0100
  Re: [PATCH] IB/hns: include linux/module.h Doug Ledford <dledford@redhat.com> - 2017-02-19 15:00 +0100

csiph-web