Re: [PATCH] RDMA/qedr: Fix some error handling

From	Doug Ledford <dledford@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] RDMA/qedr: Fix some error handling
Date	2017-02-19 15:00 +0100
Message-ID	<tcAbT-83c-5@gated-at.bofh.it> (permalink)
References	<tcbGx-1lW-9@gated-at.bofh.it>
Organization	Red Hat, Inc.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, 2017-02-18 at 12:28 +0100, Christophe JAILLET wrote:
> 'qedr_alloc_pbl_tbl()' can not return NULL.
> 
> In qedr_init_user_queue():
>  - simplify the test for the return value, no need to test for NULL
>  - propagate the error pointer if needed, otherwise 0 (success) is
> returned.
>    This is spurious.
> 
> In init_mr_info():
>  - test the return value with IS_ERR
>  - propagate the error pointer if needed instead of an exlictit
> -ENOMEM.
>    This is a no-op as the only error pointer that we can have here is
>    already -ENOMEM
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks, applied.

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
   
Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] RDMA/qedr: Fix some error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-02-18 12:50 +0100
  RE: [PATCH] RDMA/qedr: Fix some error handling "Amrani, Ram" <Ram.Amrani@cavium.com> - 2017-02-19 12:50 +0100
  Re: [PATCH] RDMA/qedr: Fix some error handling Doug Ledford <dledford@redhat.com> - 2017-02-19 15:00 +0100

csiph-web