Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582729

Re: [PATCH 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

Show all headers | View raw

Hi Matthew,

On Wed, Feb 15, 2017 at 1:10 PM,  <matthew.gerlach@linux.intel.com> wrote:

> +static int alt_pr_fpga_write_complete(struct fpga_manager *mgr,
> +                                     struct fpga_image_info *info)
> +{
> +       u32 i;
> +
> +       for (i = 0; i < info->config_complete_timeout_us; i++) {
> +               switch (alt_pr_fpga_state(mgr)) {
> +               case FPGA_MGR_STATE_WRITE_ERR:
> +                       return -EIO;
> +
> +               case FPGA_MGR_STATE_OPERATING:
> +                       dev_info(&mgr->dev,
> +                                "successful partial reconfiguration\n");
> +                       return 0;
> +
> +               default:
> +                       break;
> +               }
> +               udelay(1);

Does this need to be a udelay? would a usleep_range() do maybe?

Could we maybe pull the timeout part into the framework if all drivers are doing
is to wait / poll for the state to be a certain value?

Thanks,

Moritz

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Altera Partial Reconfiguration IP matthew.gerlach@linux.intel.com - 2017-02-15 22:20 +0100
  [PATCH 1/4] fpga: add config complete timeout matthew.gerlach@linux.intel.com - 2017-02-15 22:20 +0100
  [PATCH 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP. matthew.gerlach@linux.intel.com - 2017-02-15 22:20 +0100
    Re: [PATCH 2/4] fpga pr ip: Core driver support for Altera Partial  Reconfiguration IP. Moritz Fischer <moritz.fischer@ettus.com> - 2017-02-16 18:40 +0100
      Re: [PATCH 2/4] fpga pr ip: Core driver support for Altera Partial  Reconfiguration IP. matthew.gerlach@linux.intel.com - 2017-02-16 23:50 +0100
  [PATCH 3/4] fpga dt: bindings for Altera Partial Reconfiguraion IP. matthew.gerlach@linux.intel.com - 2017-02-15 22:20 +0100
    Re: [PATCH 3/4] fpga dt: bindings for Altera Partial Reconfiguraion IP. Dinh Nguyen <dinh.linux@gmail.com> - 2017-02-17 14:40 +0100
      Re: [PATCH 3/4] fpga dt: bindings for Altera Partial Reconfiguraion IP. Moritz Fischer <mdf@kernel.org> - 2017-02-17 16:30 +0100
    Re: [PATCH 3/4] fpga dt: bindings for Altera Partial Reconfiguraion  IP. Rob Herring <robh@kernel.org> - 2017-02-27 15:40 +0100
      Re: [PATCH 3/4] fpga dt: bindings for Altera Partial Reconfiguraion  IP. matthew.gerlach@linux.intel.com - 2017-02-27 17:40 +0100

csiph-web