Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582725

Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task()

Show all headers | View raw

On 02/16/2017 03:34 AM, Byungchul Park wrote:
> pick_next_pushable_dl_task(rq) has BUG_ON(rq->cpu != task_cpu(task))
> when it returns a task other than NULL, which means that task_cpu(task)
> must be rq->cpu. So if task == next_task, then task_cpu(next_task) must
> be rq->cpu as well. Remove the redundant condition and make code simpler.
> 
> By this patch, unnecessary one branch and two LOAD operations in 'if'
> statement can be avoided.
> 
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Reviewed-by: Juri Lelli <juri.lelli@arm.com>

+1

Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>

-- Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] sched/deadline: Remove unnecessary condition in push_dl_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 03:40 +0100
  Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in  push_dl_task() Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-16 18:40 +0100
  Re: [PATCH v3 1/2] sched/deadline: Remove unnecessary condition in  push_dl_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-22 06:10 +0100

csiph-web