Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582802

Re: [PATCH 1/6] x86/platform/uv/BAU: Declare bau_operations struct after other BAU structs

Show all headers | View raw

On Tue, 14 Feb 2017, Andrew Banman wrote:

> We must declare bau_operations after the other BAU structs so that we may
> reference them in the bau_operations function declarations.

This changelog is misleading. I really had to look twice to figure out that
this is just a preparatory patch for adding stuff which references a bau
struct later. There is no 'MUST declare after'. You always can forward
declare structs when you only use a pointer in the struct op
declaration. Sure you can avoid it, but then please tell so, e.g.:

  Move the bau_operations declaration after bau struct declaration so the
  bau structs can be referenced when adding new functions to
  bau_operations. That way we avoid forward declarations of the bau
  structs.

Hmm?

>  
> +/* Abstracted BAU functions */
> +struct bau_operations {
> +	unsigned long	(*read_l_sw_ack)(void);
> +	unsigned long	(*read_g_sw_ack)(int pnode);
> +	unsigned long	(*bau_gpa_to_offset)(unsigned long vaddr);
> +	void		(*write_l_sw_ack)(unsigned long mmr);
> +	void		(*write_g_sw_ack)(int pnode, unsigned long mmr);
> +	void		(*write_payload_first)(int pnode, unsigned long mmr);
> +	void		(*write_payload_last)(int pnode, unsigned long mmr);

I appreciate that you made them tabular aligned!

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] x86/platform/uv/BAU: UV4 message completion and initialization updates Andrew Banman <abanman@hpe.com> - 2017-02-15 03:00 +0100
  [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits Andrew Banman <abanman@hpe.com> - 2017-02-15 03:00 +0100
    Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate  message status bits Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:10 +0100
  [PATCH 5/6] x86/platform/uv/BAU: Remove initial write to swack register Andrew Banman <abanman@hpe.com> - 2017-02-15 03:10 +0100
    Re: [PATCH 5/6] x86/platform/uv/BAU: Remove initial write to swack  register Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:30 +0100
  [PATCH 1/6] x86/platform/uv/BAU: Declare bau_operations struct after other BAU structs Andrew Banman <abanman@hpe.com> - 2017-02-15 03:10 +0100
    Re: [PATCH 1/6] x86/platform/uv/BAU: Declare bau_operations struct  after other BAU structs Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:10 +0100

csiph-web