Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits
Date	2017-02-16 19:10 +0100
Message-ID	<tbyFb-1Cv-7@gated-at.bofh.it> (permalink)
References	<taX2V-1eA-7@gated-at.bofh.it> <taX2W-1eA-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 14 Feb 2017, Andrew Banman wrote:

> The location of the ERROR and BUSY status bits depends on the descriptor
> index, i.e. the CPU, of the message. We determine this location ahead of
> the wait_completion loop to avoid repeating the calculation.
> 
> Split out the status location calculation into a new routine,
> status_mmr_loc, to be used within each uv*_wait_completion routine.

And the reason for this is? You just tell WHAT you are doing, not the WHY.

Looking at the patch which implements the uv4 wait function it uses the
thing as well. So for the casual reader there is no point.

The only reason i figured why you want to do that is to reduce the number
of arguments to the wait function, correct?

If yes, then spell it out. If no, please enlighten me.

Thanks,

	tglx

Thread

[PATCH 0/6] x86/platform/uv/BAU: UV4 message completion and initialization updates Andrew Banman <abanman@hpe.com> - 2017-02-15 03:00 +0100
  [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate message status bits Andrew Banman <abanman@hpe.com> - 2017-02-15 03:00 +0100
    Re: [PATCH 2/6] x86/platform/uv/BAU: Add status_mmr_loc to locate  message status bits Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:10 +0100
  [PATCH 5/6] x86/platform/uv/BAU: Remove initial write to swack register Andrew Banman <abanman@hpe.com> - 2017-02-15 03:10 +0100
    Re: [PATCH 5/6] x86/platform/uv/BAU: Remove initial write to swack  register Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:30 +0100
  [PATCH 1/6] x86/platform/uv/BAU: Declare bau_operations struct after other BAU structs Andrew Banman <abanman@hpe.com> - 2017-02-15 03:10 +0100
    Re: [PATCH 1/6] x86/platform/uv/BAU: Declare bau_operations struct  after other BAU structs Thomas Gleixner <tglx@linutronix.de> - 2017-02-16 19:10 +0100

csiph-web