Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()

From	Juri Lelli <juri.lelli@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()
Date	2017-02-16 09:50 +0100
Message-ID	<tbpVf-3Kb-5@gated-at.bofh.it> (permalink)
References	<tbk9b-8g7-9@gated-at.bofh.it> <tbk9b-8g7-7@gated-at.bofh.it> <tbkiR-8jx-1@gated-at.bofh.it> <tbowa-2Uw-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On 16/02/17 16:15, byungchul.park wrote:
> > -----Original Message-----
> > From: Steven Rostedt [mailto:rostedt@goodmis.org]
> > Sent: Thursday, February 16, 2017 11:46 AM
> > To: Byungchul Park
> > Cc: peterz@infradead.org; mingo@kernel.org; linux-kernel@vger.kernel.org;
> > juri.lelli@gmail.com; kernel-team@lge.com
> > Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in
> > push_rt_task()
> > 
> > On Thu, 16 Feb 2017 11:34:17 +0900
> > Byungchul Park <byungchul.park@lge.com> wrote:
> > 
> > > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
> > > it returns a task other than NULL, which means that task_cpu(task) must
> > > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
> > > rq->cpu as well. Remove the redundant condition and make code simpler.
> > >
> > > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > > statement can be avoided.
> > >
> > > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
> > > ---
> > 
> > This is a different patch, I don't believe Juri reviewed it yet.
> 
> Hello juri,
> 
> I should have asked you first and been more careful before I added
> 'reviewed-by'. Can I ask you for your opinion about the additional one?
> 

Looks good to me, you can leave my Reviewed-by.

Steve, thanks for pointing out that I didn't yet reviewed it. :)

Thanks,

- Juri

Thread

[PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 03:40 +0100
  Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Steven Rostedt <rostedt@goodmis.org> - 2017-02-16 03:50 +0100
    Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 04:10 +0100
    RE: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() "byungchul.park" <byungchul.park@lge.com> - 2017-02-16 08:20 +0100
      Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Juri Lelli <juri.lelli@arm.com> - 2017-02-16 09:50 +0100
  Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-16 18:40 +0100

csiph-web