Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()

From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()
Date	2017-02-16 04:10 +0100
Message-ID	<tbkCd-dN-9@gated-at.bofh.it> (permalink)
References	<tbk9b-8g7-9@gated-at.bofh.it> <tbk9b-8g7-7@gated-at.bofh.it> <tbkiR-8jx-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 15, 2017 at 09:45:37PM -0500, Steven Rostedt wrote:
> On Thu, 16 Feb 2017 11:34:17 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
> 
> > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
> > it returns a task other than NULL, which means that task_cpu(task) must
> > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
> > rq->cpu as well. Remove the redundant condition and make code simpler.
> > 
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> > 
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
> > ---
> 
> This is a different patch, I don't believe Juri reviewed it yet.

I will take care not to make this kind of mistake next time.

Thank you very much.

> 
> -- Steve

Thread

[PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 03:40 +0100
  Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Steven Rostedt <rostedt@goodmis.org> - 2017-02-16 03:50 +0100
    Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Byungchul Park <byungchul.park@lge.com> - 2017-02-16 04:10 +0100
    RE: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task() "byungchul.park" <byungchul.park@lge.com> - 2017-02-16 08:20 +0100
      Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Juri Lelli <juri.lelli@arm.com> - 2017-02-16 09:50 +0100
  Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in  push_rt_task() Daniel Bristot de Oliveira <bristot@redhat.com> - 2017-02-16 18:40 +0100

csiph-web