Re: powerpc/xmon: Fix data-breakpoint

From	Michael Ellerman <patch-notifications@ellerman.id.au>
Newsgroups	linux.kernel
Subject	Re: powerpc/xmon: Fix data-breakpoint
Date	2017-02-16 07:10 +0100
Message-ID	<tbnqq-283-17@gated-at.bofh.it> (permalink)
References	<sGfyN-5hl-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2016-11-22 at 09:25:59 UTC, Ravi Bangoria wrote:
> Xmon data-breakpoint feature is broken.
> 
> Whenever there is a watchpoint match occurs, hw_breakpoint_handler will
> be called by do_break via notifier chains mechanism. If watchpoint is
> registered by xmon, hw_breakpoint_handler won't find any associated
> perf_event and returns immediately with NOTIFY_STOP. Similarly, do_break
> also returns without notifying to xmon.
> 
> Solve this by returning NOTIFY_DONE when hw_breakpoint_handler does not
> find any perf_event associated with matched watchpoint.
> 
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/c21a493a2b44650707d06741601894

cheers

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: powerpc/xmon: Fix data-breakpoint Michael Ellerman <patch-notifications@ellerman.id.au> - 2017-02-16 07:10 +0100

csiph-web