Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1582229

Re: [GIT] Networking

Show all headers | View raw

On Wed, Feb 15, 2017 at 5:31 PM, David Miller <davem@davemloft.net> wrote:
>
> 3) More gracefully handle rhashtable insertion errors when vmalloc is
>    not possible, from Herbert Xu.

Ugh.

So I pulled this, but when I look at his code, I'm really not sure
that I should have, and I haven't pushed the result out. I'm pretty
sure I will unpull.

This code looks like it could *easily*  have subtle issues, and looks
like the kind of thing that should go in a merge window.

The merge commit has this re-assuring sentence in it from Herbert:

 "I've tested this with test_rhashtable and it appears to work."

and this is during the  very last week of an rc release.

None of the commits even talk about why this was needed in the first
place, so there's no indication that this new scary code was really so
high-priority that it absolutely *has* to go into a late rc release.
None of it is marked for stable either, since networking never does
that.

So David, you really need to convince me that this pull is truly required.

                Linus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT] Networking David Miller <davem@davemloft.net> - 2017-02-16 02:40 +0100
  Re: [GIT] Networking Linus Torvalds <torvalds@linux-foundation.org> - 2017-02-16 03:10 +0100
    Re: [GIT] Networking David Miller <davem@davemloft.net> - 2017-02-16 04:40 +0100
      Re: [GIT] Networking David Miller <davem@davemloft.net> - 2017-02-16 04:40 +0100

csiph-web