Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From: Rob Herring <robh@kernel.org>
Newsgroups: linux.kernel
Subject: Re: [PATCH 03/10] media: dt-bindings: vpif: extend the example with  an output port
Date: Wed, 15 Feb 2017 23:10:01 +0100
Message-ID: <tbfVT-5G3-9@gated-at.bofh.it>
References: <t8h7P-5ki-3@gated-at.bofh.it> <t8h7Q-5ki-13@gated-at.bofh.it>
X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jFAQax/9w02au4Ru+gK/TyyFyLaMxMl+8PPADsZ1xY8=; b=Uz7NlU18/24yo1jGlNBFAdWT5qU4jWC0UEgykjd6MUsbQe1KP/UMBmOuWy/GNiVa+h no5aL4KeaXvD18FUxjgfqtvujXx+jD1lEYAK1P52jGg/F3iHciicAYGc2lqnNEq0EKKa Zjdylt/4+Lvt3RwWi/gNmO+VxA2+WZYPMaE1VmxAGpl8Tc6JnMQeQOOSXB9fJPobg3wp j/NQyA3UncoU/aSMf6iWqNnI5iLGy61dHJDitpiStVqzfAEyqAqJ94msme1bFAGG/Xx3 E/Gyhb7p8YlNWVR+oYYJZc4uhBBgJRneTGnlKkfMApuD1Xnsmx20mdg+dH07UVoLlSpA bDuQ==
X-Gm-Message-State: AMke39kLGmRIhbpt6NMD53iD957XON+vnjiPVs3DpWcc66Kb40LP/+5r09l7b/fr+vyghQ==
X-Received: by 10.202.245.214 with SMTP id t205mr18994851oih.52.1487196504140; Wed, 15 Feb 2017 14:08:24 -0800 (PST)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.6.2-neo (2016-08-21)
Sender: robomod@news.nic.it
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Approved: robomod@news.nic.it
Lines: 53
Organization: linux.* mail to news gateway
X-Original-Cc: Kevin Hilman <khilman@kernel.org>, Sekhar Nori <nsekhar@ti.com>, Patrick Titiano <ptitiano@baylibre.com>, Michael Turquette <mturquette@baylibre.com>, Mark Rutland <mark.rutland@arm.com>, Russell King <linux@armlinux.org.uk>, Alexandre Bailon <abailon@baylibre.com>, David Lechner <david@lechnology.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Lad Prabhakar <prabhakar.csengg@gmail.com>, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org
X-Original-Date: Wed, 15 Feb 2017 16:08:22 -0600
X-Original-Message-ID: <20170215220822.nsws6kzrd6ihvmqt@rob-hp-laptop>
X-Original-References: <1486485683-11427-1-git-send-email-bgolaszewski@baylibre.com> <1486485683-11427-4-git-send-email-bgolaszewski@baylibre.com>
X-Original-Sender: linux-kernel-owner@vger.kernel.org
Xref: csiph.com linux.kernel:1581707

On Tue, Feb 07, 2017 at 05:41:16PM +0100, Bartosz Golaszewski wrote:
> This makes the example more or less correspond with the da850-evm
> hardware setup.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  .../devicetree/bindings/media/ti,da850-vpif.txt    | 35 ++++++++++++++++++----
>  1 file changed, 29 insertions(+), 6 deletions(-)

Spoke too soon...

> 
> diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> index 9c7510b..543f6f3 100644
> --- a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt
> @@ -28,19 +28,27 @@ I2C-connected TVP5147 decoder:
>  		reg = <0x217000 0x1000>;
>  		interrupts = <92>;
>  
> -		port {
> -			vpif_ch0: endpoint@0 {
> +		port@0 {
> +			vpif_input_ch0: endpoint@0 {
>  				reg = <0>;
>  				bus-width = <8>;
> -				remote-endpoint = <&composite>;
> +				remote-endpoint = <&composite_in>;
>  			};
>  
> -			vpif_ch1: endpoint@1 {
> +			vpif_input_ch1: endpoint@1 {
>  				reg = <1>;
>  				bus-width = <8>;
>  				data-shift = <8>;
>  			};
>  		};
> +
> +		port@1 {

The binding doc says nothing about supporting a 2nd port. 


> +			vpif_output_ch0: endpoint@0 {
> +				reg = <0>;

Don't need reg here.

> +				bus-width = <8>;
> +				remote-endpoint = <&composite_out>;
> +			};
> +		};
>  	};