Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls

From	Bandan Das <bsd@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls
Date	2017-02-17 18:30 +0100
Message-ID	<tbUw1-7dc-15@gated-at.bofh.it> (permalink)
References	<tb946-1ef-21@gated-at.bofh.it> <tbEhz-5gH-3@gated-at.bofh.it> <tbMoO-1Y8-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Paolo Bonzini <pbonzini@redhat.com> writes:

> ----- Original Message -----
>> From: "Bandan Das" <bsd@redhat.com>
>> To: "Paolo Bonzini" <pbonzini@redhat.com>
>> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
>> Sent: Friday, February 17, 2017 1:04:14 AM
>> Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls
>> 
>> Paolo Bonzini <pbonzini@redhat.com> writes:
>> 
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> > ---
>> 
>> I took a quick look and found these two potential
>> consumers of these set/clear wrappers.
>> 
>> vmcs_set_secondary_exec_control()
>> vmx_set_virtual_x2apic_mode()
>> 
>> Since this has been reviewed already,
>> we can just have them later in a follow up
>> (unless you left them out intentionally).
>
> Both of these can both set and clear bits, so they could be the
> consumer of a new function
>
> void vmcs_write_bits(u16 field, u32 value, u32 mask)
>
> but I don't see much benefit in introducing it; the cognitive
> load is higher than vmcs_{set,clear}_bits.

Yes, agreed. Thanks!

> Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Paolo Bonzini <pbonzini@redhat.com> - 2017-02-15 15:50 +0100
  Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based  execution controls Radim Krčmář <rkrcmar@redhat.com> - 2017-02-16 17:30 +0100
  Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution  controls David Hildenbrand <david@redhat.com> - 2017-02-16 20:30 +0100
  Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Bandan Das <bsd@redhat.com> - 2017-02-17 01:10 +0100
    Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based  execution controls Paolo Bonzini <pbonzini@redhat.com> - 2017-02-17 09:50 +0100
      Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Bandan Das <bsd@redhat.com> - 2017-02-17 18:30 +0100

csiph-web