Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1583211

Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls

Show all headers | View raw

----- Original Message -----
> From: "Bandan Das" <bsd@redhat.com>
> To: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
> Sent: Friday, February 17, 2017 1:04:14 AM
> Subject: Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls
> 
> Paolo Bonzini <pbonzini@redhat.com> writes:
> 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> 
> I took a quick look and found these two potential
> consumers of these set/clear wrappers.
> 
> vmcs_set_secondary_exec_control()
> vmx_set_virtual_x2apic_mode()
> 
> Since this has been reviewed already,
> we can just have them later in a follow up
> (unless you left them out intentionally).

Both of these can both set and clear bits, so they could be the
consumer of a new function

void vmcs_write_bits(u16 field, u32 value, u32 mask)

but I don't see much benefit in introducing it; the cognitive
load is higher than vmcs_{set,clear}_bits.

Paolo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Paolo Bonzini <pbonzini@redhat.com> - 2017-02-15 15:50 +0100
  Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based  execution controls Radim Krčmář <rkrcmar@redhat.com> - 2017-02-16 17:30 +0100
  Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution  controls David Hildenbrand <david@redhat.com> - 2017-02-16 20:30 +0100
  Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Bandan Das <bsd@redhat.com> - 2017-02-17 01:10 +0100
    Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based  execution controls Paolo Bonzini <pbonzini@redhat.com> - 2017-02-17 09:50 +0100
      Re: [PATCH] KVM: VMX: use vmcs_set/clear_bits for CPU-based execution controls Bandan Das <bsd@redhat.com> - 2017-02-17 18:30 +0100

csiph-web