Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1583372

Re: [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for configuring EP functions

From Kishon Vijay Abraham I <kishon@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for configuring EP functions
Date 2017-02-17 13:10 +0100
Message-ID <tbPwl-47n-9@gated-at.bofh.it> (permalink)
References <tbNux-2Ef-5@gated-at.bofh.it> <tbNuy-2Ef-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

On Friday 17 February 2017 03:20 PM, Kishon Vijay Abraham I wrote:
> Introduce a new configfs entry to configure the EP function (like
> configuring the standard configuration header entries) and to
> bind the EP function with EP controller.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  drivers/pci/endpoint/Kconfig      |   14 +-
>  drivers/pci/endpoint/Makefile     |    1 +
>  drivers/pci/endpoint/pci-ep-cfs.c |  427 +++++++++++++++++++++++++++++++++++++
>  3 files changed, 440 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/pci/endpoint/pci-ep-cfs.c
> 
> diff --git a/drivers/pci/endpoint/Kconfig b/drivers/pci/endpoint/Kconfig
> index 7eb1c79..8470f0b 100644
> --- a/drivers/pci/endpoint/Kconfig
> +++ b/drivers/pci/endpoint/Kconfig
> @@ -6,7 +6,6 @@ menu "PCI Endpoint"
>  
>  config PCI_ENDPOINT
>  	bool "PCI Endpoint Support"
> -	select CONFIGFS_FS
>  	help
>  	   Enable this configuration option to support configurable PCI
>  	   endpoint. This should be enabled if the platform has a PCI
> @@ -14,8 +13,19 @@ config PCI_ENDPOINT
>  
>  	   Enabling this option will build the endpoint library, which
>  	   includes endpoint controller library and endpoint function
> -	   library.
> +	   library. This will also enable the configfs entry required to
> +	   configure the endpoint function and used to bind the
> +	   function with a endpoint controller.

This chunk shouldn't be added. I've missed removing this (it's added below).
I'll wait to get other review comments before sending a new revision.

Thanks
Kishon

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 00/22] PCI: Support for configurable PCI endpoint Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
    Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 14:20 +0100
    Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support Joao Pinto <Joao.Pinto@synopsys.com> - 2017-02-17 18:30 +0100
  [PATCH v2 22/22] ARM: DRA7: clockdomain: Change the CLKTRCTRL of CM_PCIE_CLKSTCTRL to SW_WKUP Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 15/22] PCI: Add device IDs for DRA74x and DRA72x Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 21/22] MAINTAINERS: add PCI EP maintainer Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 06/22] PCI: endpoint: functions: Add an EP function to test PCI Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 05/22] Documentation: PCI: Add specification for the *pci test* function device Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 18/22] tools: PCI: Add a userspace tool to test PCI endpoint Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for configuring EP functions Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
    Re: [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for  configuring EP functions Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 13:10 +0100
    Re: [PATCH v2 03/22] PCI: endpoint: Introduce configfs entry for  configuring EP functions Christoph Hellwig <hch@infradead.org> - 2017-02-17 18:10 +0100
  [PATCH v2 17/22] Documentation: misc-devices: Add Documentation for pci-endpoint-test driver Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 10/22] PCI: dwc: dra7xx: Facilitate wrapper and msi interrupts to be enabled independently Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 11/22] PCI: dwc: dra7xx: Add EP mode support Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 20/22] Documentation: PCI: Add userguide for PCI endpoint test function Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 19/22] tools: PCI: Add sample test script to invoke pcitest Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 02/22] Documentation: PCI: Guide to use PCI Endpoint Core Layer Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
    Re: [PATCH v2 02/22] Documentation: PCI: Guide to use PCI Endpoint  Core Layer Joao Pinto <Joao.Pinto@synopsys.com> - 2017-02-17 12:50 +0100
  [PATCH v2 16/22] misc: Add host side pci driver for pci test function device Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:00 +0100
  [PATCH v2 07/22] Documentation: PCI: Add binding documentation for pci-test endpoint function Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:10 +0100
  [PATCH v2 13/22] PCI: dwc: dra7xx: Workaround for errata id i870 Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:10 +0100
  [PATCH v2 09/22] dt-bindings: PCI: Add dt bindings for pci designware EP mode Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:10 +0100
  [PATCH v2 12/22] dt-bindings: PCI: dra7xx: Add dt bindings for pci dra7xx EP mode Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:10 +0100
  [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to enable legacy mode Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 11:10 +0100
    Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to  enable legacy mode Rob Herring <robh@kernel.org> - 2017-02-27 18:20 +0100
      Re: [PATCH v2 14/22] dt-bindings: PCI: dra7xx: Add dt bindings to  enable legacy mode Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-28 06:30 +0100
  Re: [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP  controller and EP functions Kishon Vijay Abraham I <kishon@ti.com> - 2017-02-17 12:40 +0100
    Re: [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP  controller and EP functions Joao Pinto <Joao.Pinto@synopsys.com> - 2017-02-17 12:50 +0100

csiph-web