Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581355

[PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous.

Show all headers | View raw

From: Alexander GQ Gerasiov <gq@cs.msu.su>

On some devices interrupt may be invoked by parasitic assert event produced
while switching from high to low. Such interrupt should be ignored.

Signed-off-by: Alexander GQ Gerasiov <gq@cs.msu.su>
---
 drivers/pps/clients/pps_parport.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/pps/clients/pps_parport.c b/drivers/pps/clients/pps_parport.c
index 37094b0..39c1fea 100644
--- a/drivers/pps/clients/pps_parport.c
+++ b/drivers/pps/clients/pps_parport.c
@@ -69,6 +69,8 @@ static void parport_irq(void *handle)
 	struct pps_event_time ts_assert, ts_clear;
 	struct pps_client_pp *dev = handle;
 	struct parport *port = dev->pardev->port;
+	static struct pps_event_time prev;
+	static struct timespec64 ts_delta;
 	unsigned int i;
 	unsigned long flags;
 
@@ -95,9 +97,14 @@ static void parport_irq(void *handle)
 	/* check the signal (no signal means the pulse is lost this time) */
 	if (!signal_is_set(port)) {
 		local_irq_restore(flags);
-		dev_err(dev->pps->dev, "lost the signal\n");
+		ts_delta = timespec64_sub(ts_assert.ts_real, prev.ts_real);
+		/* do not print error message in case interrupt handler is
+		 * invoked by parasitic assert event */
+		if (timespec64_to_ns(&ts_delta) > (NSEC_PER_SEC / 2))
+			dev_err(dev->pps->dev, "lost the signal\n");
 		goto out_none;
 	}
+	prev = ts_assert;
 
 	/* poll the port until the signal is unset */
 	for (i = dev->cw; i; i--)
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] LinuxPPS: some minor fixes and improvements. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 2/8] ntp/pps: ignore pps_valid decreasing if there is no pps signal. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event(). Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 7/8] LinuxPPS: pps_gen_parport: Add polarity parameter for inverted signal. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 3/8] hardpps: fix some pps_jitter issues. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100

csiph-web