Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1581358

[PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event().

Show all headers | View raw

From: Alexander GQ Gerasiov <gq@redlab-i.ru>

Otherwise we get "scheduling while atomic" problem.

Signed-off-by: Alexander GQ Gerasiov <gq@redlab-i.ru>
---
 drivers/pps/kapi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
index 805c749..a9a111d 100644
--- a/drivers/pps/kapi.c
+++ b/drivers/pps/kapi.c
@@ -226,11 +226,11 @@ void pps_event(struct pps_device *pps, struct pps_event_time *ts, int event,
 	/* Wake up if captured something */
 	if (captured) {
 		pps->last_ev++;
+		spin_unlock_irqrestore(&pps->lock, flags);
 		wake_up_interruptible_all(&pps->queue);
-
 		kill_fasync(&pps->async_queue, SIGIO, POLL_IN);
-	}
 
-	spin_unlock_irqrestore(&pps->lock, flags);
+	} else
+		spin_unlock_irqrestore(&pps->lock, flags);
 }
 EXPORT_SYMBOL(pps_event);
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] LinuxPPS: some minor fixes and improvements. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 6/8] LinuxPPS: pps_parport: Ignore interrupt invoked less than 0.5sec after previous. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 2/8] ntp/pps: ignore pps_valid decreasing if there is no pps signal. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 8/8] LinuxPPS: pps_gen_parport: Add check for bad clocksource. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 4/8] LinuxPPS: kapi: Unlock before waking up events queue in pps_event(). Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 5/8] LinuxPPS: pps_parport: Do not generate assert in case of lost signal. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 7/8] LinuxPPS: pps_gen_parport: Add polarity parameter for inverted signal. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100
  [PATCH 3/8] hardpps: fix some pps_jitter issues. Andrey Drobyshev <immortalguardian1@gmail.com> - 2017-02-15 15:40 +0100

csiph-web