Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1581266

Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading

From Alan Cox <alan@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading
Date 2017-02-15 13:20 +0100
Message-ID <tb6IV-8jM-5@gated-at.bofh.it> (permalink)
References <tb50t-78r-3@gated-at.bofh.it> <tb50t-78r-1@gated-at.bofh.it> <tb5tv-7iH-5@gated-at.bofh.it> <tb5tv-7iH-3@gated-at.bofh.it>
Organization Intel Corporation

Show all headers | View raw


> > > I'm seriously grumpy about this engineering trainwreck, which has
> > > seven
> > > SOBs from Intel developers for 50 lines of code. And none of them
> > > figured
> > > out that this is broken. Impressive fail!

It was discussed at the time, documented at the time. Unfortunately the
people who did the emulator didn't feel the urge to provide a way to
detect the platform was Goldfish.

Historically it also used its own custom device discovery scheme. Given
the limited use of older versions of Goldfish it might well make sense
to remove support for the older emulator versions.

Alan

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[patch 1/2] x86/platform/goldfish: Prevent unconditional loading Thomas Gleixner <tglx@linutronix.de> - 2017-02-15 11:30 +0100
  Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional  loading Thomas Gleixner <tglx@linutronix.de> - 2017-02-15 12:00 +0100
    Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading Alan Cox <alan@linux.intel.com> - 2017-02-15 13:20 +0100
      Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional  loading Thomas Gleixner <tglx@linutronix.de> - 2017-02-15 16:00 +0100
  Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading Peter Zijlstra <peterz@infradead.org> - 2017-02-15 12:00 +0100

csiph-web