Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading
Date	2017-02-15 12:00 +0100
Message-ID	<tb5tv-7iH-5@gated-at.bofh.it> (permalink)
References	<tb50t-78r-3@gated-at.bofh.it> <tb50t-78r-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 15, 2017 at 11:11:50AM +0100, Thomas Gleixner wrote:
> The goldfish platform code registers the platform device unconditionally
> which causes havoc in several ways if the goldfish_pdev_bus driver is
> enabled:
> 
>  - Access to the hardcoded physical memory region, which is either not
>    available or contains stuff which is completely unrelated.
> 
>  - Prevents that the interrupt of the serial port can be requested
> 
>  - In case of a spurious interrupt it goes into a infinite loop in the
>    interrupt handler of the pdev_bus driver (which needs to be fixed
>    seperately).
> 
> Add a 'goldfish' command line option to make the registration opt-in when
> the platform is compiled in.
> 
> I'm seriously grumpy about this engineering trainwreck, which has seven
> SOBs from Intel developers for 50 lines of code. And none of them figured
> out that this is broken. Impressive fail!
> 
> Fixes: ddd70cf93d78 ("goldfish: platform device for x86")
> Reported-by: Gabriel C <nix.or.die@gmail.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: stable@vger.kernel.org

Just thinking, could we not simply delete this entire driver and use
x86-DT support to setup this platform?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch 1/2] x86/platform/goldfish: Prevent unconditional loading Thomas Gleixner <tglx@linutronix.de> - 2017-02-15 11:30 +0100
  Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional  loading Thomas Gleixner <tglx@linutronix.de> - 2017-02-15 12:00 +0100
    Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading Alan Cox <alan@linux.intel.com> - 2017-02-15 13:20 +0100
      Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional  loading Thomas Gleixner <tglx@linutronix.de> - 2017-02-15 16:00 +0100
  Re: [patch 1/2] x86/platform/goldfish: Prevent unconditional loading Peter Zijlstra <peterz@infradead.org> - 2017-02-15 12:00 +0100

csiph-web