Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs

From	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs
Date	2017-02-13 20:00 +0100
Message-ID	<tau0V-7vg-1@gated-at.bofh.it> (permalink)
References	<tasit-6AY-5@gated-at.bofh.it> <tasiu-6AY-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 02/13/2017 12:03 PM, Paul Durrant wrote:
> The code sets the default return code to -ENOSYS but then overrides this
> to -EINVAL in the switch() statement's default case, which is clearly
> silly.
>
> This patch removes the override and sets the default return code to
> -ENOTTY, which is the conventional return for an unimplemented ioctl.
>
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Applied to for-linus-4.11.

-boris

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs Paul Durrant <paul.durrant@citrix.com> - 2017-02-13 18:10 +0100
  Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented  IOCTLs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-13 20:00 +0100

csiph-web