[PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs

From	Paul Durrant <paul.durrant@citrix.com>
Newsgroups	linux.kernel
Subject	[PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs
Date	2017-02-13 18:10 +0100
Message-ID	<tasiu-6AY-7@gated-at.bofh.it> (permalink)
References	<tasit-6AY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The code sets the default return code to -ENOSYS but then overrides this
to -EINVAL in the switch() statement's default case, which is clearly
silly.

This patch removes the override and sets the default return code to
-ENOTTY, which is the conventional return for an unimplemented ioctl.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>

v2:
- Use -ENOTTY rather than -ENOSYS
---
 drivers/xen/privcmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c
index 6e3306f..5e5c7ae 100644
--- a/drivers/xen/privcmd.c
+++ b/drivers/xen/privcmd.c
@@ -551,7 +551,7 @@ static long privcmd_ioctl_mmap_batch(void __user *udata, int version)
 static long privcmd_ioctl(struct file *file,
 			  unsigned int cmd, unsigned long data)
 {
-	int ret = -ENOSYS;
+	int ret = -ENOTTY;
 	void __user *udata = (void __user *) data;
 
 	switch (cmd) {
@@ -572,7 +572,6 @@ static long privcmd_ioctl(struct file *file,
 		break;
 
 	default:
-		ret = -EINVAL;
 		break;
 	}
 
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented IOCTLs Paul Durrant <paul.durrant@citrix.com> - 2017-02-13 18:10 +0100
  Re: [PATCH v3 1/3] xen/privcmd: return -ENOTTY for unimplemented  IOCTLs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-02-13 20:00 +0100

csiph-web