Re: [PATCH] proc/sysctl: prune stale dentries during unregistering

From	ebiederm@xmission.com (Eric W. Biederman)
Newsgroups	linux.kernel
Subject	Re: [PATCH] proc/sysctl: prune stale dentries during unregistering
Date	2017-02-13 11:00 +0100
Message-ID	<talAn-1ZB-35@gated-at.bofh.it> (permalink)
References	<t8STM-4gx-23@gated-at.bofh.it> <t9dYe-q5-15@gated-at.bofh.it> <t9e7T-tH-9@gated-at.bofh.it> <t9ehB-xE-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Konstantin Khlebnikov <khlebnikov@yandex-team.ru> writes:

> On 10.02.2017 10:47, Al Viro wrote:
>> On Fri, Feb 10, 2017 at 10:35:02AM +0300, Konstantin Khlebnikov wrote:
>>
>>> # time sysctl -a > /dev/null
>>> real    1m12.806s
>>> user    0m0.016s
>>> sys     1m12.400s
>>>
>>> Currently only memory reclaimer could remove this garbage.
>>> But without significant memory pressure this never happens.
>>>
>>> This patch collects sysctl inodes into list on sysctl table header and
>>> prunes all their dentries once that table unregisters.
>>
>> I'd probably go for hlist, but that's mostly cosmetic difference; how about
>> the matching stats *after* that patch?
>>
>
> dcache size doesn't grow endlessly, so stats are fine
>
> # sysctl fs.dentry-state
> fs.dentry-state = 92712	58376	45	0	0	0
>
> # time sysctl -a &>/dev/null
>
> real	0m0.013s
> user	0m0.004s
> sys	0m0.008s

Applied thanks,

Eric

Thread

[PATCH] proc/sysctl: drop unregistered stale dentries as soon as  possible Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-02-08 12:00 +0100
  Re: [PATCH] proc/sysctl: drop unregistered stale dentries as soon  as possible Andrew Morton <akpm@linux-foundation.org> - 2017-02-08 22:50 +0100
    Re: [PATCH] proc/sysctl: drop unregistered stale dentries as soon as  possible Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-09 05:00 +0100
      Re: [PATCH] proc/sysctl: drop unregistered stale dentries as soon as possible Konstantin Khlebnikov <koct9i@gmail.com> - 2017-02-09 08:40 +0100
        Re: [PATCH] proc/sysctl: drop unregistered stale dentries as soon as  possible Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-09 10:10 +0100
          [PATCH] proc/sysctl: prune stale dentries during unregistering Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-02-10 08:40 +0100
            Re: [PATCH] proc/sysctl: prune stale dentries during unregistering Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-10 08:50 +0100
              Re: [PATCH] proc/sysctl: prune stale dentries during unregistering Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-02-10 09:00 +0100
                Re: [PATCH] proc/sysctl: prune stale dentries during unregistering ebiederm@xmission.com (Eric W. Biederman) - 2017-02-13 11:00 +0100
            Re: [PATCH] proc/sysctl: prune stale dentries during unregistering Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-02-18 20:00 +0100
              Re: [PATCH] proc/sysctl: prune stale dentries during unregistering Al Viro <viro@ZenIV.linux.org.uk> - 2017-02-19 09:50 +0100
                [REVIEW][PATCH] proc/sysctl: Don't grab i_lock under sysctl_lock. ebiederm@xmission.com (Eric W. Biederman) - 2017-02-21 02:50 +0100
                Re: [REVIEW][PATCH] proc/sysctl: Don't grab i_lock under sysctl_lock. Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2017-02-21 09:50 +0100
                Re: [REVIEW][PATCH] proc/sysctl: Don't grab i_lock under sysctl_lock. ebiederm@xmission.com (Eric W. Biederman) - 2017-02-21 20:40 +0100

csiph-web