[PATCH V2] mtd: spi-nor: intel: use true/false for boolean

From	Nicholas Mc Guire <der.herr@hofr.at>
Newsgroups	linux.kernel
Subject	[PATCH V2] mtd: spi-nor: intel: use true/false for boolean
Date	2017-02-13 09:20 +0100
Message-ID	<tak1A-18Q-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

writeable in struct intel_spi is a boolean and assignment should be to
true/false not 1/0 as recommended by boolinit.cocci.

Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
---

make coccicheck complained with:
 ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1

Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)

Patch is against 4.10-rc7 (localversion-next is next-20170213)

 drivers/mtd/spi-nor/intel-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index 4630716..2956f2c 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
 		 * whole partition read-only to be on the safe side.
 		 */
 		if (intel_spi_is_protected(ispi, base, limit))
-			ispi->writeable = 0;
+			ispi->writeable = false;
 
 		end = (limit << 12) + 4096;
 		if (end > part->size)
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V2] mtd: spi-nor: intel: use true/false for boolean Nicholas Mc Guire <der.herr@hofr.at> - 2017-02-13 09:20 +0100
  Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean Marek Vasut <marek.vasut@gmail.com> - 2017-02-14 06:10 +0100
    Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-02-14 11:10 +0100
      Re: [PATCH V2] mtd: spi-nor: intel: use true/false for boolean Marek Vasut <marek.vasut@gmail.com> - 2017-02-15 22:20 +0100

csiph-web