Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1580708

Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

Show all headers | View raw

On 02/15, Aleksa Sarai wrote:
>
> >This is an extra pointer to task_struct and more lines of code to
> >accomplish the same thing. Why would we want to do that?
>
> I don't think it's more "actual" lines of code (I think the wrapping is
> inflating the line number count),

I too think it doesn't make sense to blow task_struct and the generated code.
And to me this patch doesn't make the source code more clean.

> but switching it means that it's more in
> line with other queues in the kernel (it took me a bit to figure out what
> was going on with oom_reaper_list beforehand).

perhaps you can turn oom_reaper_list into llist_head then. This will also
allow to remove oom_reaper_lock. Not sure this makes sense too.

Oleg.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] oom_reaper: switch to struct list_head for reap queue Aleksa Sarai <asarai@suse.de> - 2017-02-14 16:10 +0100
  Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Johannes Weiner <hannes@cmpxchg.org> - 2017-02-14 17:40 +0100
    Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Aleksa Sarai <asarai@suse.de> - 2017-02-14 18:00 +0100
      Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Oleg Nesterov <oleg@redhat.com> - 2017-02-14 18:40 +0100
        Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Aleksa Sarai <asarai@suse.de> - 2017-02-15 10:10 +0100
          Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Michal Hocko <mhocko@kernel.org> - 2017-02-20 17:00 +0100
      Re: [PATCH] oom_reaper: switch to struct list_head for reap queue Ingo Molnar <mingo@kernel.org> - 2017-02-15 09:10 +0100

csiph-web