[PATCH] xfs: fix len comparison in xfs_extent_busy_trim

Path	csiph.com!1.us.feeder.erje.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] xfs: fix len comparison in xfs_extent_busy_trim
Date	Tue, 14 Feb 2017 18:10:02 +0100
Message-ID	<taOM2-4Ah-41@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.9.0
X-Provags-ID	V03:K0:DtlcRkM+Q61CT2XOrBey0DUCg13upgkOB8yuKkrmggJ/vcwUraU nbg41vzSHUIWIMhIyDmwnhhiVdFbsfzBUO5qxZ4B5uPwz/7X5KCjpBRHx4OGHmKnqjQzbwC 36MkKhbkKVMZYvl/R6ZMUn2aWz8ApZc6ts8MzuzL4q3ob9ucmJ/HqdIDgdFH6xqvnSdk5cD kFv2iO7AmeShBbEB3obWw==
X-Ui-Out-Filterresults	notjunk:1;V01:K0:mKaY15BpdGY=:TJOmw9tev+FL65wA11yTG3 McT9UkGzseRjoo/ORFm1sVgwFRBkuzJjXtAZML0dcItKb6uU6IxO5KWHDx01I6ghFAfcuMTop a3Egk7Fa/CQumXwfIWVyxjEvMF/dnaMC6PtDhk0NkDv0wWNBl4sLAHKeCAbpdeerd2W1Cie+2 eaw/O8V7OY3wjF1x/qZ8FeVK0SrE0mYGeF65JJM+m/r93rv4Zrnn/4qmT4AureBithYURRX1G JJ6qMZ2NYQNkOw0GaShPFc+e15g0/15666b5KP+uq4dGxHanQKapRYKOWaB8mW0H/IgcAzw05 rdZkkbqXQ9+9+q/pyAfSJ5RCGoTeRCFfh+VJ1m/qos0n99qvrKsDAoVJiNtLeqA6ejIbOSLHz h+cjjlFCCd8Xea+QyYxEFGjj1pZEKzJgh04I6C6PQZ7U/n9Xar3XjOSE8R4eg1BsdX+u7XffW M54gdEIDdoaBEfGilexVdNVh16sxHvZre2Zg+QkYljPjRtrxIlp3uo862hFGabJiXCGn74hZp Kcm1nrHDBQJNJPLTv9+4tjSLHgfeq55lTFbTpRqyiG76EpwYaUXdJdkNFqEUa/o3NhMZTwFfS E9YxrhUzfnuaT2IUIw48wH09OPpAGREECOENT5/fq72VNjh6yVGlNDJvoaNNGLKvjTbihvNpt /esaF5142MdsWm8NPABAfrz7BUl1ts/3vL4bZBrixObDAJ7eHPW1/OOBRnAur1XCzaPg=
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	Christoph Hellwig <hch@lst.de>, Arnd Bergmann <arnd@arndb.de>, Dave Chinner <dchinner@redhat.com>, Brian Foster <bfoster@redhat.com>, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 14 Feb 2017 18:08:30 +0100
X-Original-Message-ID	<20170214170836.2705798-1-arnd@arndb.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1580683

Show key headers only | View raw

The length is now passed by reference, so the assertion has to be updated
to match the other changes, as pointed out by this W=1 warning:

fs/xfs/xfs_extent_busy.c: In function 'xfs_extent_busy_trim':
fs/xfs/xfs_extent_busy.c:356:13: error: ordered comparison of pointer with integer zero [-Werror=extra]

Fixes: ebf55872616c ("xfs: improve handling of busy extents in the low-level allocator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 fs/xfs/xfs_extent_busy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_extent_busy.c b/fs/xfs/xfs_extent_busy.c
index ab062610234e..77760dbf0242 100644
--- a/fs/xfs/xfs_extent_busy.c
+++ b/fs/xfs/xfs_extent_busy.c
@@ -353,7 +353,7 @@ xfs_extent_busy_trim(
 	struct rb_node		*rbp;
 	bool			ret = false;
 
-	ASSERT(len > 0);
+	ASSERT(*len > 0);
 
 	spin_lock(&args->pag->pagb_lock);
 restart:
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] xfs: fix len comparison in xfs_extent_busy_trim Arnd Bergmann <arnd@arndb.de> - 2017-02-14 18:10 +0100
  Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim Christoph Hellwig <hch@lst.de> - 2017-02-14 20:20 +0100
  Re: [PATCH] xfs: fix len comparison in xfs_extent_busy_trim "Darrick J. Wong" <darrick.wong@oracle.com> - 2017-02-15 03:20 +0100

csiph-web